Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Proposed changes #2

Open
wdavidw opened this Issue · 0 comments

1 participant

@wdavidw

Hi,

After using, i encountered a few concerns which i wanted to share with you. For illustration, i just pushed my code to "https://github.com/wdavidw/node-hive":

  • Creating client each time the execute method is called didn't work for me. For exemple running use my_db, set my.property=value, INSERT ... need to be run inside the same connection (or client)
  • Move generated Thrift code from node_module to src
  • Added multi version layout/support
  • Use NPM to load the Thrift module
  • API with only query, execute and end function similar to yours

Currently, data parsing after executing a query is simpler than yours since i dont retrieve the schema but this could be added.

Are you interested into merging the 2 modules? i would take care of everything but that implies a breaking of your API/behavior. Otherwise i'll publish it separately. I leave the decision up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.