Fix equality operator arguments #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...which avoids overload resolution ambiguities in C++20, when a synthesized candidate of operator == for a reversed-argument rewrite conflicts with the actual operator ==, as one is a template specialization for int and the other for float. (As observed with recent Clang 10 trunk with -std=c++2a when building libstaroffice as part of LibreOffice: > STOFFChart.cxx:230:63: error: use of overloaded operator '==' is ambiguous (with operand types 'STOFFVec2f' (aka 'STOFFVec2<float>') and 'STOFFVec2i' (aka 'STOFFVec2<int>')) > bool autoPlace=m_legendPosition==STOFFBox2f()||m_dimension==STOFFVec2i(); > ~~~~~~~~~~~^ ~~~~~~~~~~~~ > ./libstaroffice_internal.hxx:687:8: note: candidate function > bool operator==(STOFFVec2<T> const &p) const > ^ > ./libstaroffice_internal.hxx:687:8: note: candidate function (with reversed parameter order) > STOFFChart.cxx:270:63: error: use of overloaded operator '==' is ambiguous (with operand types 'STOFFVec2f' (aka 'STOFFVec2<float>') and 'STOFFVec2i' (aka 'STOFFVec2<int>')) > bool autoPlace=m_plotAreaPosition==STOFFBox2f()||m_dimension==STOFFVec2i(); > ~~~~~~~~~~~^ ~~~~~~~~~~~~ > ./libstaroffice_internal.hxx:687:8: note: candidate function > bool operator==(STOFFVec2<T> const &p) const > ^ > ./libstaroffice_internal.hxx:687:8: note: candidate function (with reversed parameter order) )
fosnola
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which avoids overload resolution ambiguities in C++20, when a synthesized
candidate of operator == for a reversed-argument rewrite conflicts with the
actual operator ==, as one is a template specialization for int and the other
for float. (As observed with recent Clang 10 trunk with -std=c++2a when
building libstaroffice as part of LibreOffice:
)