Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Surge link in README #737

Merged
merged 1 commit into from May 24, 2019
Merged

Conversation

felixonmars
Copy link
Member

Fixes #736

Copy link
Member

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of that use relative link.

@felixonmars
Copy link
Member Author

Instead of that use relative link.

How to do that when the file is not in the repo?

@@ -33,7 +33,7 @@ Our chat channel is on gitter here: https://gitter.im/fossasia/susi_server
* **Step 5:** Build locally by running : ```$ npm run build ```
* **Step 6:** To deploy at a url use : ```$ npm run deploy ```

### Running on [Surge](./docs/INSTALLATION_SURGE.md)
### Running on [Surge](https://github.com/fossasia/chat.susi.ai/blob/master/docs/INSTALLATION_SURGE_ENGLISH.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think having a link here is required at all. The README itself has all the instructions for working with Sure.

@mariobehling mariobehling merged commit 4f710a6 into fossasia:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead "Surge" link in README
4 participants