Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #328 - displayed error for invalid app #329

Merged
merged 1 commit into from Aug 27, 2017
Merged

fixes #328 - displayed error for invalid app #329

merged 1 commit into from Aug 27, 2017

Conversation

djmgit
Copy link
Member

@djmgit djmgit commented Aug 26, 2017 •
edited

Fixes issue #328, displayed error for invalid app name
query in details page url.

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

@djmgit
Copy link
Member Author

djmgit commented Aug 26, 2017

Test link: http://loklakapps.surge.sh/details.html?q=xyz

@kavithaenair @Achint08 @SKrPl @vibhcool open for review.

kavithaenair
kavithaenair reviewed Aug 26, 2017
View reviewed changes
Copy link
Member

@kavithaenair kavithaenair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image and the text are not properly aligned in the center. Please check that.
image

@djmgit
fixes loklak#328 - displayed error for invalid app
9cc1251 
Fixes issue loklak#328, displayed error for invalid app name
query in details page url.
@djmgit
Copy link
Member Author

djmgit commented Aug 27, 2017

@kavithaenair made changes, please re-review.

vibhcool
vibhcool approved these changes Aug 27, 2017
View reviewed changes
Copy link
Member

@vibhcool vibhcool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

@mariobehling mariobehling merged commit d8eefc8 into loklak:master Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibhcool vibhcool vibhcool approved these changes

@kavithaenair kavithaenair kavithaenair approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@djmgit @vibhcool @kavithaenair @mariobehling