Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Added about section #265

Merged
merged 1 commit into from May 4, 2019

Conversation

@yashk2000
Copy link
Member

yashk2000 commented May 4, 2019

Fixes #259

Changes: Added an about section.

Screenshots for the change:
Screenshot_20190504-130220
Screenshot_20190504-123949

@yashk2000 yashk2000 force-pushed the yashk2000:about branch from 9342cb7 to c4e7feb May 4, 2019
@yashk2000

This comment has been minimized.

Copy link
Member Author

yashk2000 commented May 4, 2019

@yashk2000 yashk2000 force-pushed the yashk2000:about branch from 1025bd1 to 2f8f629 May 4, 2019
Copy link
Contributor

adityastic left a comment

Make Library Icons and License Icons a bit smaller

@adityastic

This comment has been minimized.

Copy link
Contributor

adityastic commented May 4, 2019

Center vertical align them according to the title and the subtitle of the layout on the right

@yashk2000

This comment has been minimized.

Copy link
Member Author

yashk2000 commented May 4, 2019

@adityastic the size is the same as the GitHub icon. I will center align it. Just a minute.

Co-authored-by: Aditya Gupta <adityastic@users.noreply.github.com>
@yashk2000 yashk2000 force-pushed the yashk2000:about branch from 46d0d84 to 6da2e85 May 4, 2019
@yashk2000

This comment has been minimized.

Copy link
Member Author

yashk2000 commented May 4, 2019

@adityastic done. I reduced the icon size to 28dp for license icons.

@adityastic

This comment has been minimized.

Copy link
Contributor

adityastic commented May 4, 2019

@yashk2000 please update the screenshot

@yashk2000

This comment has been minimized.

Copy link
Member Author

yashk2000 commented May 4, 2019

@adityastic done.

@mariobehling mariobehling merged commit 95fb9ed into fossasia:development May 4, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.