New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SVG-background (Inkscape+SVG editing issue) #20

Closed
niccokunzmann opened this Issue Sep 11, 2017 · 8 comments

Comments

3 participants
@niccokunzmann
Member

niccokunzmann commented Sep 11, 2017


The images like this have the following properties:

  1. They have a fix color
  2. They have a marker like "EXHIBITOR" written on them.

I would like to have my own text on thie beautiful background but with my own color.

Possible Solution:

Create an SVG file without the exhibitor text.
The triangles all have one color e.g. #33ee66, so that I can replace the color with find and replace in this SVG file. To change the brightness, you can add a grey triange above them. You can make it totally black and just change the transparency value.
You can use Inkscape to create the file.

@rupav

This comment has been minimized.

Show comment
Hide comment
@rupav

rupav Sep 18, 2017

Member

@niccokunzmann
I would like to work on this.
Please guide me where can I start looking in this codebase.

Member

rupav commented Sep 18, 2017

@niccokunzmann
I would like to work on this.
Please guide me where can I start looking in this codebase.

@niccokunzmann

This comment has been minimized.

Show comment
Hide comment
@niccokunzmann

niccokunzmann Sep 18, 2017

Member

@rupav Sure, welcome! If you need anything, please let us know. Also, if you created a prototype instead fo an allaround perfect 100% forever solution, please also let us know :)

Member

niccokunzmann commented Sep 18, 2017

@rupav Sure, welcome! If you need anything, please let us know. Also, if you created a prototype instead fo an allaround perfect 100% forever solution, please also let us know :)

@rupav

This comment has been minimized.

Show comment
Hide comment
@rupav

rupav Sep 18, 2017

Member

@niccokunzmann you were referring to this image. Right? Which 'document' are you referring to in your comment ?

https://github.com/fossasia/badgeyay/blob/development/app/static/uploads/exhibitor.png?raw=true]

Member

rupav commented Sep 18, 2017

@niccokunzmann you were referring to this image. Right? Which 'document' are you referring to in your comment ?

https://github.com/fossasia/badgeyay/blob/development/app/static/uploads/exhibitor.png?raw=true]

@niccokunzmann

This comment has been minimized.

Show comment
Hide comment
@niccokunzmann

niccokunzmann Sep 18, 2017

Member

@rupav Thanks, yes, this is the image. I changed "document" to SVG file because that is what I mean.

Member

niccokunzmann commented Sep 18, 2017

@rupav Thanks, yes, this is the image. I changed "document" to SVG file because that is what I mean.

@rupav

This comment has been minimized.

Show comment
Hide comment
@rupav

rupav Sep 18, 2017

Member

@niccokunzmann
One last ques.
As I earlier talked on gitter channel about this issue,I came to know that this is not codebase related issue.
So you basically want to get svg file created on Inkspace with your given requirements? I will work on this. :)

Member

rupav commented Sep 18, 2017

@niccokunzmann
One last ques.
As I earlier talked on gitter channel about this issue,I came to know that this is not codebase related issue.
So you basically want to get svg file created on Inkspace with your given requirements? I will work on this. :)

@niccokunzmann

This comment has been minimized.

Show comment
Hide comment
@niccokunzmann

niccokunzmann Sep 18, 2017

Member

So "not codebase" means, that you do not need to setup the project, write python code, ...
So, in this issue you can focus on the basics: create a contribution, create a pull-request, get it approved.

So you basically want to get svg file created on Inkspace with your given requirements?

Yes.

Member

niccokunzmann commented Sep 18, 2017

So "not codebase" means, that you do not need to setup the project, write python code, ...
So, in this issue you can focus on the basics: create a contribution, create a pull-request, get it approved.

So you basically want to get svg file created on Inkspace with your given requirements?

Yes.

@rupav

This comment has been minimized.

Show comment
Hide comment
@rupav

rupav Sep 20, 2017

Member

Hi @niccokunzmann , @jajodiaraghav , I want to share my progress and need a suggestion:
2017-09-20

So i created this abstract background( quite similar to the required one using 'voronoi diagram'). Now Here I have used 'pick color from layer 1' to color all the triangles, due to which all triangles are Seperable or Ungrouped Entities/Objects. Now if I want to change the color to say 'Orange', I will have to change the 'Fill as can be seen in XML text editor' for all the objects/triangles.

Can you please explain your Possible Solution in the root comment of this issue :).

Does your suggestion mean this :
Is there a way around if I can make all triangles 'Fill' parameter with some variable. Only opacity/alpha factor will then just make the required background i.e. We will just need to change this variable in 'XML file/ SVG file' and everything will fall in place?

Member

rupav commented Sep 20, 2017

Hi @niccokunzmann , @jajodiaraghav , I want to share my progress and need a suggestion:
2017-09-20

So i created this abstract background( quite similar to the required one using 'voronoi diagram'). Now Here I have used 'pick color from layer 1' to color all the triangles, due to which all triangles are Seperable or Ungrouped Entities/Objects. Now if I want to change the color to say 'Orange', I will have to change the 'Fill as can be seen in XML text editor' for all the objects/triangles.

Can you please explain your Possible Solution in the root comment of this issue :).

Does your suggestion mean this :
Is there a way around if I can make all triangles 'Fill' parameter with some variable. Only opacity/alpha factor will then just make the required background i.e. We will just need to change this variable in 'XML file/ SVG file' and everything will fall in place?

@rupav

This comment has been minimized.

Show comment
Hide comment
@rupav

rupav Sep 21, 2017

Member

Got the idea :), will submit my PR ASAP.

Member

rupav commented Sep 21, 2017

Got the idea :), will submit my PR ASAP.

@rupav rupav referenced this issue Sep 22, 2017

Merged

Fixes #20 #152

2 of 2 tasks complete

@fossasia-bot fossasia-bot bot added the has-PR label Sep 22, 2017

gabru-md added a commit that referenced this issue Sep 22, 2017

rupav added a commit to rupav/badgeyay that referenced this issue Sep 23, 2017

add background image with FOSSASIA logo
worked on fossasia#20 image, to add FOSSASIA logo(non - editable)

@fossasia-bot fossasia-bot bot added the has-PR label Sep 23, 2017

rupav added a commit to rupav/badgeyay that referenced this issue Sep 23, 2017

add background image with FOSSASIA logo
worked on fossasia#20 image, to add FOSSASIA logo(non - editable)

add background with FOSSASIA and heading(editable)

Heading can be edited in the text editor.

rupav added a commit to rupav/badgeyay that referenced this issue Sep 25, 2017

fixes issue fossasia#20.
Find 'layer 1', then change the 'fill'  attribute wih required color code in your text editor.

devshiva619 added a commit to devshiva619/badgeyay that referenced this issue Sep 30, 2017

Fixes fossasia#20
Find 'layer 1', then replace the value of the 'fill' attribute with required color code in your text editor.

devshiva619 added a commit to devshiva619/badgeyay that referenced this issue Sep 30, 2017

add background image with FOSSASIA logo
worked on fossasia#20 image, to add FOSSASIA logo(non - editable)

add background with FOSSASIA and heading(editable)

Heading can be edited in the text editor.

ParthS007 added a commit that referenced this issue Nov 12, 2017

Updating master (#360)
* Update README.md

* Web UI for CSV upload

* Update README.md

* Update README.md

* Version pinning packages

* Added menu and version

* Changed MIT License to GLPv3

* Add optional feature to upload PNG as badge background

* Remove duplicate file

* Textarea to enter csv data

* Fix error typo

* Rearranged external files and removed duplicates

* Fix travis error

* Add template for pull request and issue

* Add .editorconfig for linting purposes

* Clarify maintainance rules (#34)

* Clarify maintainance rules

* change chat room

* fix spelling looking

* address doing nothing

* Split up being on the team and being removed

* Documented editorconfig part and also change issue template

* Update README.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Add link

* <br> removed

* Update README.md

* Documented editorconfig part and also change issue template

* Allows downloading of badges in zipped, pdf and svg versions

* Code files,badges all are present in separate folders

* Remove files generated from previous uploads

* fixes #4 - Added option to upload a custon config file in json format

Fixes issue #4, Added option to upload custom config file.
Also added a default config file to the project. The name of the
uploaded file should be of the form <background_image_name>.json
just like the csv file names.

* Add dockerfile

* Python linter 'Pyflakes' added

* Add Dockerfile

* Autodeployment on Heroku

* Add anonymizer for eventyay exports (#54)

* add anonymizer for eventyay exports

* remove os import

https://travis-ci.org/fossasia/badgeyay/builds/275205709#L633

* errors no longer pass silently

added traceback.print_exc() in main.py to print out the exceptions/errors occuring

Fixes #47

* solves 500 error on missing folder

added a snippet to check for the badges folder everytime. and make the folder if it does not exists.
changed os.path.join('static','badges') with BADGES_FOLDER and added explanation for empty_directory() method.

Fixes #58

* Add documentation of heroku deployment (#60)

* Add documentation of heroku deployment

* Update docker.md

* script.js: Changes Dropdown Behaviour

Earlier to close the links dropbox in the header
the user needed to click on the glyficon again.
Now clicking anywhere outside the dropbox will close it.

Fixes #65

* Add option to select from default backgrounds (#68)

* Eventyay

* req,docker

* update main.py

resolving conflicts

update main.py

* Creates PDF/ZIP only if user ticks on it. (#72)

merge_badges.py file is taken from #71 and further tweaking is done on it. index.html is changed to be updated with the new changes. and main.py is also changed. style.css is also changed with accordance to it.

* Error shows up when no file uploaded

* Make it compulsary to select download type

* Added selenium tests

* Fixes #77 to make the page responsive (#94)

* rename urllib2 to urllib (#98)

* split up tests into setup fix #90 (#100)

* Reconfigure travis (#103)

* 6 (#102)

* Add deploy to docker button (#104)

* Fixes the design and adds test (#106)

* Fix styling of the board

* Reduce the size of issue template

* Reduce the size of PR template

* Add upload test

* Fixed footer design bug (#109)

* Fixes #29 - added option to set paper size in config file (#108)

Fixes issue #29, added option for paper size. Now users can
specify paper size in config file.

* Added debug mode

* Add validation for manual data entry and Hound CI (#107)

* Fixing tab and spaces

* Fix tests

* Added few more tests

* Update README (#117)

Readme Updated with latest Output standards with options for pdfs and zips.
Corrected links to the files and changed `merge_badges.sh` to `merge_badges.py`

Closes https://github.com/fossasia/badgeyay/issues114

* added minor spelling fixes

* fixed markup error (#121)

* Improves local development setup instructions

* UnboundLocalError 'filename' BUG resolved

'filename' referenced before assignment bug is resolved and urllib error in python2.7 generate_csv_eventyay.py
resolved

Fixes Bug #127

* Upadte

234

* Added Guidelines for User (#131)

Added guidelines for user for entering data.
The Link to the '/guide' appears only if wrong data is entered with an error.

* future error scalability. (#134)

* Added 500 error page

* Add flask-compress for opt.

* 2 (#141)

* Error resolved

* Add PhantomJS

* add phantomjs

* Update main.py

* Update .travis.yml

* Rectified Double quotes, semi-colon and shorthand realted issues

* Rectified error

* Add test report (#147)

Test Reports

* Rectified error

* Fixes #20

Find 'layer 1', then replace the value of the 'fill' attribute with required color code in your text editor.

* Version pinning

* Fix improper closing braces in script.js

* Fix minor formatting in main.py

* Make the application run again (#158)

* Adds new version of merge_badges script (#159)

Fixes issue #76, added new version of merge_badges python
script which is independent of pdftk dependency and all
the linux commands related to it.

* Added environment variable for travis (#156)

* Added environment variable (#160)

* Fix file names on download

* Updated README.md (#163)

* add background image with FOSSASIA logo

worked on #20 image, to add FOSSASIA logo(non - editable)

add background with FOSSASIA and heading(editable)

Heading can be edited in the text editor.

* Added Python-Code for preforming ZIP (#169)

Python Code is added for generating ZIPs and with few minor tweaks of other files.
All the OS commands are replaced with python library : zipfile
Tested and Works!
Will add screenshots of the app!

It is a subsiquent fix for #76

* Add requirements folder (#171)

* svg2png, bg, text

* Modify text/header (#176)

remove_trailing_spaces.

* Update README.md

Added the youtube link in README.md

* Update README.md

Added youtube link in the README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* 2

* Fixes #181:Added cairosvg in requirement file

* Modified Running locally in README.md

* Link to fork page

this reduces the click count and increases discoverability

* Fix #149: Fix travis test for desktop

* Update local.md

* Add version number for pypdf2 in requirements.txt

* Dropdown working properly

* Removing Optional Label

* svg files moved

* Changed thumbnail of video in Readme

Fixes: #185

* minor changes with double quotes

* add defused.lxml for parsing xml tree

* Added `defusedxml` to requirements.txt

Fixes #216

* removed merge_badges.sh

* added cairocffi -  removed error

* Update .gitignore

* Update .gitignore

* Added technologies to README file
Fixes: #178

* Fixes #175 Adds GIF showing the working of badgeyay

* Color Picker integration for HEX color value for Background.

Added jQuery MiniColors Color Picker which gives options to the
user to choose from several colors.

Fixes: #200

* Fixed codacy issues in scripts.js
Fixes: 223

* Bug: Remove install statements from generate_badges.py (#232)

Add Installation instructions in Readme
Fixes #219

* Fixed typo in eventyay_export_anonymizer (#236)

Fixed typo in eventyay_export_anonymizer.py instructions printed to user - "th" should be "the".

* Add LICENSE.md (#234)

* Fixes codestyles for Flake8 (#229)

* Make License.md file look professional (#241)

* Improvements in Readme.md File (#242)

* Fix misalignment of background menu (#246)

* Fixes #175 Adds Issue and Branch Policy (#251)

* Fixes badges not found (#237)

Fixes issue #168, changed python to python3 in main.py - generate_badges
method. Badges are being generated now.

* Fixed SVG page tempate (#250)

Fixes svg page template file, now it can be opened without any error. Also the configuration of badge pages code has been moved to a separate method and code has been refactored.

* Fix Readme.md (#255)

* add .dockerignore (#259)

* Changed os.system to subprocess.run (#256)

* Adds One-click deployment to Scalingo (#260)

* Fix no argument error for tocsv() call in generate_csv_eventday.py (#248)

* Rectified errors in merge_badges_v2 (#261)

* Fix the color-picker functionality (#252)

* Adds one-click deployment to Bluemix (#263)

* Modified upload button with an upload fa icon (#231)

* Correction in README.md (#266)

* Added option to set custom page size (#268)

Fixes issue #267, added option to customize page size by explicitly mentioning width and height.

* Fixes #239: Changed all the files to PEP8 Compliant (#253)

* Fix merge_badges.py error (#270)

* Fix menu rendering on small screens (#273)

* Add 'Enter custom text for badges' in index.html. This sends the 'text_on_image' argument in POST request. (#274)

* fix #275 - fixes zip file generation and download (#276)

fix issue #275, Zip file can now be generated and can be downloaded.

* Converted single quotes to double quotes (#277)

* Correct a typo in readme.md (#278)

Change 'shon' to 'shown'

* Feat: Add Vagrant installation files (#279)

Fixes #235

* Heroku one click deploy button fixed (#280)

* Run Travis tests with firefox (#287)

* Rectified issues in generate_badges.py (#282)

* Changed xml to defusedxml.lxml

* Changed Try,Except,Pass to traceback.print_exec()

* Changed etree to its defusedxml form

* Fix #292 - Used cairosvg to generate pdf files (#293)

Uses Cairo-SVG to generate PDF files instead of rsvg-convert.

* Fix #290 - Prevent generation of duplicate background images. (#291)

Now for every badge folder(CSV file) only one background image file is created.

* Selecting a default background without uploading CSV shows error (#296)

* Update README.md (#300)

Fixed some typos and errors in README.md

* Removed redundant code from main.py (#297)

* Remove redundant lines (#302)

* Add user guide statically (#304)

* Fixes #195 : Documentation for testing (#305)

* Fixes link for generate_badges.py(#310) (#311)

* Generate Badges for Manual Data with pre-selected images (#316)

Changed an elif to if so that if a predefined image is used the the CSV is also checked for.
The error was caused because of the fact that elif was not executed if the if of image was encountered.
I've managed it and fixed the bug. There were several other bugs as well that I've fixed so as to implement proper functionality.
All the changes can be found in the commit section on thie PR

Fixes : #314

* Fixes#283 UI changes (#309) (#328)

* Fixes#283 UI changes (#309) (#330)

* Fixes#283 UI changes (#309) (#331)

* UI changes final (#333)

* Fixes#283 UI changes (#309)

* UI (#332)

* Fixes#283 UI changes (#309) (#328)

* Fixes#283 UI changes (#309) (#330)

* Fixes#283 UI changes (#309) (#331)

* Fix #324 - Moved user defined background and color picker to (#335)

separate section

Moved user defined background and color picker
to a separate section as color picker acts only
for user defined image.

* Corrected susi logo (#320)

Fixes #321

Signed-off-by: yashLadha <201551061@iiitvadodara.ac.in>

* Fixed Travis build (#334)

* Fixes #306 : Update version of geckodriver & mozilla in travis.yml (#337)

* Added function doc string (#326)

Fixes #319

Signed-off-by: yashLadha <201551061@iiitvadodara.ac.in>

* Allow only image files (#352)

* Add data that makes sense (#348)

* Fix indentation and mistakes (#355)

* Fix #294 - Added form validation in front end using JavaScript (#338)

Fixes issue #294, Added JS form validation, input filters and
input specific errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment