New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1300 : Badge generation message same as v1 #1313

Merged
merged 1 commit into from Jul 16, 2018

Conversation

3 participants
@yashLadha
Member

yashLadha commented Jul 15, 2018

Fixes #1300

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

;
});
</script>
</div>

This comment has been minimized.

@abishekvashok

abishekvashok Jul 15, 2018

Member

I can see under intended code here

This comment has been minimized.

@yashLadha

yashLadha Jul 15, 2018

Member

Used formatter in IDE and not giving any error @abishekvashok

This comment has been minimized.

@abishekvashok

abishekvashok Jul 15, 2018

Member

See the patch diff on github :P
Also, individual advice: Don't use an IDE, without an IDE you can become a better coder.

This comment has been minimized.

@yashLadha

yashLadha Jul 15, 2018

Member

Using VSCode really, can't say it is a text editor though

@yashLadha yashLadha force-pushed the yashLadha:1300 branch from b204436 to ef65451 Jul 15, 2018

@ParthS007

LGTM! Can you please provide a screenshot too.

@open-event-bot open-event-bot bot removed the needs-review label Jul 15, 2018

@yashLadha

This comment has been minimized.

Member

yashLadha commented Jul 15, 2018

@ParthS007 added video showing the message box and semantic progress bar element

@ParthS007 ParthS007 merged commit 1fcdee6 into fossasia:development Jul 16, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment