New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes#1354 : Add Functionality to Edit Badge Name #1449

Merged
merged 1 commit into from Jul 29, 2018

Conversation

3 participants
@ParthS007
Copy link
Member

ParthS007 commented Jul 23, 2018

Fixes #1354 #1427

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

  • Add Functionality to Edit Badge Name

image

@ParthS007 ParthS007 force-pushed the ParthS007:patch3 branch from 21a18dd to 5fdccbe Jul 23, 2018

@ParthS007

This comment has been minimized.

Copy link
Member

ParthS007 commented Jul 23, 2018

@yashLadha I am facing some problem in updating Badge Name as the action is not happening as expected. Can you please help!

@ParthS007 ParthS007 requested review from yashLadha and gabru-md Jul 23, 2018

@fossasia fossasia deleted a comment from open-event-bot bot Jul 23, 2018

@ParthS007 ParthS007 requested a review from djmgit Jul 23, 2018

@@ -21,6 +21,32 @@ export default Component.extend({
});
},

updateBadgeName() {

This comment has been minimized.

@yashLadha

yashLadha Jul 24, 2018

Member

Can ask for the badge as the parameter and send it to parent controller to update it as it happens in real time in the store.

@@ -12,7 +12,15 @@
<img src="{{badge.image_link}}">
</div>
<div class="content">
<div class="header">{{badge.badge_name}}</div>
<div class="ui form" {{action 'updateBadgeName' on="submit"}}>

This comment has been minimized.

@yashLadha

yashLadha Jul 24, 2018

Member

send badge as the parameter

@yashLadha
Copy link
Member

yashLadha left a comment

PTAL

@ParthS007

This comment has been minimized.

Copy link
Member

ParthS007 commented Jul 24, 2018

@yashLadha Done with the changes but Badge Name is not changing on submitting the form. Please take a look again.

@ParthS007

This comment has been minimized.

Copy link
Member

ParthS007 commented Jul 28, 2018

@yashLadha Can you please update your review?

@ParthS007 ParthS007 force-pushed the ParthS007:patch3 branch from f39a2f1 to 7c5cb03 Jul 28, 2018

@fossasia fossasia deleted a comment from open-event-bot bot Jul 28, 2018

@ParthS007 ParthS007 requested a review from yashLadha Jul 28, 2018

@gabru-md
Copy link
Member

gabru-md left a comment

lgtm

@open-event-bot open-event-bot bot removed the needs-review label Jul 29, 2018

@gabru-md

This comment has been minimized.

Copy link
Member

gabru-md commented Jul 29, 2018

merging this

@gabru-md gabru-md merged commit 161c581 into fossasia:development Jul 29, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ParthS007 ParthS007 deleted the ParthS007:patch3 branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment