New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample Backgrounds. #167

Merged
merged 1 commit into from Sep 23, 2017

Conversation

2 participants
@rupav
Member

rupav commented Sep 23, 2017

Fixes #155 checklist- 1,2 and 4.
Can be used for solving issue #153 4th.

Checklist

[ x] I have read the Contribution & Best practices Guide and my PR follows them.
[x ] My branch is up-to-date with the Upstream development branch.
[x ] I have added necessary documentation (if appropriate)
Changes proposed in this pull request:

Changes proposed in this pull request:

  • main points(changes proposed) are --
    -It extends the use of background with editable color, already done by me in #20.
    -It includes background with 'FOSSASIA' logo on the top which is editable.
    -Also it has a seperate file which have Heading too, like 'BUSINESS PASS' which is editable using a text editor.

Full report:
Documentation for Use.docx

@fossasia-bot

This comment has been minimized.

Show comment
Hide comment
@fossasia-bot

fossasia-bot bot Sep 23, 2017

Hi @rupav!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

fossasia-bot bot commented Sep 23, 2017

Hi @rupav!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@gabru-md

This comment has been minimized.

Show comment
Hide comment
@gabru-md

gabru-md Sep 23, 2017

Member

@rupav Why do we have two PR for the same purpose?
PS : #165

Member

gabru-md commented Sep 23, 2017

@rupav Why do we have two PR for the same purpose?
PS : #165

@rupav

This comment has been minimized.

Show comment
Hide comment
@rupav

rupav Sep 23, 2017

Member

@gabru-md for 2 seperate files. Can it be done into 1 commit without adding a folder. I am new to this.

Member

rupav commented Sep 23, 2017

@gabru-md for 2 seperate files. Can it be done into 1 commit without adding a folder. I am new to this.

@gabru-md

This comment has been minimized.

Show comment
Hide comment
@gabru-md

gabru-md Sep 23, 2017

Member

Use Git CLI:

$ git clone https://github.com/your/local/repo
$ git rebase -i HEAD~2
Change the 'pick' from one to 's'
Save the file 
$ git push origin development

and done

Member

gabru-md commented Sep 23, 2017

Use Git CLI:

$ git clone https://github.com/your/local/repo
$ git rebase -i HEAD~2
Change the 'pick' from one to 's'
Save the file 
$ git push origin development

and done

add background image with FOSSASIA logo
worked on #20 image, to add FOSSASIA logo(non - editable)

add background with FOSSASIA and heading(editable)

Heading can be edited in the text editor.
@rupav

This comment has been minimized.

Show comment
Hide comment
@rupav
Member

rupav commented Sep 23, 2017

Done @gabru-md

@gabru-md

This comment has been minimized.

Show comment
Hide comment
@gabru-md

gabru-md Sep 23, 2017

Member

@rupav I hope you understood.
Cheers!

Member

gabru-md commented Sep 23, 2017

@rupav I hope you understood.
Cheers!

@fossasia-bot

This comment has been minimized.

Show comment
Hide comment
@fossasia-bot

fossasia-bot bot Sep 23, 2017

Hi @rupav!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

fossasia-bot bot commented Sep 23, 2017

Hi @rupav!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@rupav

This comment has been minimized.

Show comment
Hide comment
@rupav

rupav Sep 23, 2017

Member

Yeah. Sure thanks for help. Understood :)

Member

rupav commented Sep 23, 2017

Yeah. Sure thanks for help. Understood :)

@fossasia-bot fossasia-bot bot removed the needs-review label Sep 23, 2017

@gabru-md gabru-md merged commit 220dfe1 into fossasia:development Sep 23, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codacy/pr Hang in there, Codacy is reviewing your Pull request.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment