New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes#383 Adding Codecov Support #400

Merged
merged 1 commit into from Dec 12, 2017

Conversation

3 participants
@ParthS007
Member

ParthS007 commented Dec 12, 2017

Fixes #383

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

  • Adds Codecov support.
@open-event-bot

This comment has been minimized.

open-event-bot bot commented Dec 12, 2017

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

open-event-bot bot commented Dec 12, 2017

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@codecov

This comment has been minimized.

codecov bot commented Dec 12, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (development@58fbac7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             development   #400   +/-   ##
============================================
  Coverage               ?   100%           
============================================
  Files                  ?      1           
  Lines                  ?     44           
  Branches               ?      0           
============================================
  Hits                   ?     44           
  Misses                 ?      0           
  Partials               ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58fbac7...61eb190. Read the comment docs.

@ParthS007

This comment has been minimized.

Member

ParthS007 commented Dec 12, 2017

@harshit98

Good work! @ParthS007

@open-event-bot open-event-bot bot removed the needs-review label Dec 12, 2017

@ParthS007 ParthS007 changed the title from [WIP]Fixes#383 Adding Codecov Support to Fixes#383 Adding Codecov Support Dec 12, 2017

@vaibhavsingh97

LGTM!

@vaibhavsingh97 vaibhavsingh97 merged commit 0bd6b8b into fossasia:development Dec 12, 2017

5 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@ParthS007 ParthS007 deleted the ParthS007:patch2 branch Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment