Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes#498 Rectify Travis CI as per new architecture #512

Merged
merged 1 commit into from Jan 24, 2018

Conversation

@ParthS007
Copy link
Member

commented Jan 23, 2018

Fixes #498

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

  • Rectify Travis CI as per new architecture
  • Run tests for the front-end and backend on isolated instances in Travis CI.
@open-event-bot

This comment has been minimized.

Copy link

commented Jan 23, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 23, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 23, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 23, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 23, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 23, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 23, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 23, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 23, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 23, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@ParthS007 ParthS007 changed the title Fixes#498 Rectify Travis CI as per new architecture [WIP]Fixes#498 Rectify Travis CI as per new architecture Jan 23, 2018

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 24, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 24, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 24, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 24, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 24, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@abishekvashok

This comment has been minimized.

Copy link
Member

commented Jan 24, 2018

@ParthS007 I think it should be py.test instead of pytest for the coverage.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 24, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 24, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 24, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 24, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

self.Responses = json.load(open(self.ResponsesPath))
self.URL = 'http://127.0.0.1:5000/api/v1.0/generate_badges'
app.config['TESTING'] = True
self.app = app.test_client()

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 24, 2018

'app' may be undefined, or defined from star imports: app.main

self.ResponsesPath = os.path.abspath(os.path.join(os.getcwd(), 'backend/app/tests/expected_responses.json'))
self.Responses = json.load(open(self.ResponsesPath))
self.URL = 'http://127.0.0.1:5000/api/v1.0/generate_badges'
app.config['TESTING'] = True

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 24, 2018

'app' may be undefined, or defined from star imports: app.main


import sys
sys.path.append("../..")
from app.main import *

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 24, 2018

module level import not at top of file
'from app.main import *' used; unable to detect undefined names

@open-event-bot

This comment has been minimized.

Copy link

commented Jan 24, 2018

Hi @ParthS007!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@ParthS007 ParthS007 changed the title [WIP]Fixes#498 Rectify Travis CI as per new architecture Fixes#498 Rectify Travis CI as per new architecture Jan 24, 2018

@codecov

This comment has been minimized.

Copy link

commented Jan 24, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (development@cbea1c1). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             development   #512   +/-   ##
============================================
  Coverage               ?   100%           
============================================
  Files                  ?      1           
  Lines                  ?     43           
  Branches               ?      0           
============================================
  Hits                   ?     43           
  Misses                 ?      0           
  Partials               ?      0
Impacted Files Coverage Δ
backend/app/tests/test_api.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbea1c1...a359a57. Read the comment docs.

@abishekvashok
Copy link
Member

left a comment

Wow, great work.
Looks exceptionally great.

@open-event-bot open-event-bot bot removed the needs-review label Jan 24, 2018

@abishekvashok

This comment has been minimized.

Copy link
Member

commented Jan 24, 2018

@ParthS007 can you squash the commits down to a single meaning full commit that explain whats done. I can also squash and merge if you wish but the latter is more professional. What do you think?

@ParthS007

This comment has been minimized.

Copy link
Member Author

commented Jan 24, 2018

@abishekvashok Please wait for 2 hours , I have classes now , will squash with a proper commit message .I hope you understand 👍 I will post link on Gitter channel when I am completely done with it.

@abishekvashok

This comment has been minimized.

Copy link
Member

commented Jan 24, 2018

Sure you are free to take all the time in the world @ParthS007 :)

@S2606

S2606 approved these changes Jan 24, 2018

Copy link
Member

left a comment

LGTM!

@vaibhavsingh97
Copy link
Member

left a comment

Woah @ParthS007 Excellent work!!
Perfect PR 😀
LGTM!

@vaibhavsingh97

This comment has been minimized.

Copy link
Member

commented Jan 24, 2018

Waiting for travis build, will approve 👍

@harshit98
Copy link
Member

left a comment

Awesome! 💯
Keep up the good work! 🎉

@harshit98 harshit98 merged commit 58b63db into fossasia:development Jan 24, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.