New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #805 : Adding greeting and verification email functionality using Firebase #806

Merged
merged 1 commit into from May 21, 2018

Conversation

3 participants
@yashLadha
Copy link
Member

yashLadha commented May 20, 2018

Fixes #805

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Preview Link

Changes proposed in this pull request:

  • Added greeting email functionality
  • Added verification mail on user registration through email and password

Youtube Video to ease review process :

@codecov

This comment has been minimized.

Copy link

codecov bot commented May 20, 2018

Codecov Report

Merging #806 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           development   #806   +/-   ##
==========================================
  Coverage          100%   100%           
==========================================
  Files                1      1           
  Lines               43     43           
==========================================
  Hits                43     43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1245eb6...0b8bcd7. Read the comment docs.

@yashLadha yashLadha force-pushed the yashLadha:http-email branch from ea17535 to bff3208 May 20, 2018

@yashLadha yashLadha force-pushed the yashLadha:http-email branch from bff3208 to 0b8bcd7 May 20, 2018

@open-event-bot open-event-bot bot removed the needs-review label May 20, 2018

@yashLadha

This comment has been minimized.

Copy link
Member

yashLadha commented May 21, 2018

@djmgit

djmgit approved these changes May 21, 2018

@djmgit djmgit merged commit 3d4f37d into fossasia:development May 21, 2018

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected when comparing 1245eb6...0b8bcd7
Details
codecov/project 100% remains the same compared to 1245eb6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

This was referenced May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment