New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #914 : Implemented checkbox logic #926

Merged
merged 1 commit into from Jun 4, 2018

Conversation

4 participants
@yashLadha
Copy link
Member

yashLadha commented Jun 4, 2018

Fixes #914

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Preview Link

Changes proposed in this pull request:

  • Added logic for badge generation using other components
  • Added accordion for checkbox logic for nice experience.

Sample UI :

image

@ParthS007
Copy link
Member

ParthS007 left a comment

LGTM !

@open-event-bot open-event-bot bot removed the needs-review label Jun 4, 2018

@djmgit

djmgit approved these changes Jun 4, 2018

Copy link
Member

djmgit left a comment

Cool 👍

@djmgit djmgit merged commit 0341d8e into fossasia:development Jun 4, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment