New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #992 : Added Password Reset mail functionality #994

Merged
merged 1 commit into from Jun 13, 2018

Conversation

4 participants
@yashLadha
Copy link
Member

yashLadha commented Jun 12, 2018

Fixes #992

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Preview Link

Changes proposed in this pull request:

  • Added forgot password logic

PS : Will iterate over this PR to implement the logic for the reset mail on firebase side

@yashLadha yashLadha force-pushed the yashLadha:forgot-password branch from a59da14 to b71695e Jun 12, 2018

@open-event-bot

This comment has been minimized.

Copy link

open-event-bot bot commented Jun 12, 2018

Hi @yashLadha!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

open-event-bot bot commented Jun 12, 2018

Hi @yashLadha!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@djmgit

This comment has been minimized.

Copy link
Member

djmgit commented Jun 13, 2018

@yashLadha please check the failing tests.

@yashLadha

This comment has been minimized.

Copy link
Member

yashLadha commented Jun 13, 2018

Looking into it @djmgit

@yashLadha yashLadha force-pushed the yashLadha:forgot-password branch from b71695e to 55b3f47 Jun 13, 2018

@open-event-bot

This comment has been minimized.

Copy link

open-event-bot bot commented Jun 13, 2018

Hi @yashLadha!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@yashLadha yashLadha force-pushed the yashLadha:forgot-password branch from 55b3f47 to 4823348 Jun 13, 2018

@yashLadha

This comment has been minimized.

Copy link
Member

yashLadha commented Jun 13, 2018

Resolved it @djmgit

@ParthS007
Copy link
Member

ParthS007 left a comment

LGTM !

@open-event-bot open-event-bot bot removed the needs-review label Jun 13, 2018

@djmgit

djmgit approved these changes Jun 13, 2018

Copy link
Member

djmgit left a comment

Nice work 👍

@djmgit djmgit merged commit 0c713c3 into fossasia:development Jun 13, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment