New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix dimension of images, add title overlay and Play Store and F-Droid badges #528
Conversation
…ay Store, F-Droid badge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure that all screenshots of apps have the same width x height. Don't squeeze them or stretch them. Part of this issue to ensure they all have the same dimensions. Please ensure the following images have the same width x height and list it in the PR description. One main goal of the issue to ensure conformity across app images:
- SUSI.AI-Android.jpg W ?? x H ??
- PSLab_Android.jpg W ?? x H ??
- Phimpme_android.jpg W ?? x H ??
- Eventyay_Organizer_Android.jpg W ?? x H ??
- Eventyay_Attendee_Android.jpg W ?? x H ??
- Badge_Magic_Android.jpg W ?? x H ??
Provide a test page. Follow best practices always! |
Please take care of the whole issue instead of bit-sizing it: #527 |
@mariobehling Updated. |
Please also make the overlay gray a bit darker. The info is difficult to read. |
@mariobehling Updated, please have a look. Where should the GitHub badge be added, next to the Play Store and F-Droid badges? |
|
@mariobehling Updated. |
Also made the text darker so that it is easily readable. |
@ShridharGoel All the photos are pixelating, Can you increase the resolution a bit so that they don't pixelate. |
@ShridharGoel Please provide a non-pixelated resolution and an actual Github Badge. All three Playstore, Fdroid, Github badges should have the same size. |
Merging this as WIP. @ShridharGoel Please finalize the points mentioned here. |
@mariobehling On it. |
@ShridharGoel any updates on this? |
Fixes #526 and #527
Changes:
Link for testing: https://shridhargoel.github.io/fossasia.org/