Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix dimension of images, add title overlay and Play Store and F-Droid badges #528

Merged
merged 8 commits into from Aug 28, 2019

Conversation

ShridharGoel
Copy link
Member

@ShridharGoel ShridharGoel commented Aug 14, 2019

Fixes #526 and #527

Changes:

  • Updated images to use the recent ones.
  • Updated dimensions of all images. (364 x 647)
  • Added title overlay for images.
  • Added Play Store and F-Droid badges.

Link for testing: https://shridhargoel.github.io/fossasia.org/

@ShridharGoel ShridharGoel changed the title chore: Fix dimension of Organizer App image, add title overlay and Play Store, F-Droid badge chore: Fix dimension of Organizer App image, add title overlay and Play Store and F-Droid badges Aug 14, 2019
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that all screenshots of apps have the same width x height. Don't squeeze them or stretch them. Part of this issue to ensure they all have the same dimensions. Please ensure the following images have the same width x height and list it in the PR description. One main goal of the issue to ensure conformity across app images:

  • SUSI.AI-Android.jpg W ?? x H ??
  • PSLab_Android.jpg W ?? x H ??
  • Phimpme_android.jpg W ?? x H ??
  • Eventyay_Organizer_Android.jpg W ?? x H ??
  • Eventyay_Attendee_Android.jpg W ?? x H ??
  • Badge_Magic_Android.jpg W ?? x H ??

@mariobehling
Copy link
Member

Provide a test page. Follow best practices always!

@mariobehling
Copy link
Member

Please take care of the whole issue instead of bit-sizing it: #527

@ShridharGoel ShridharGoel changed the title chore: Fix dimension of Organizer App image, add title overlay and Play Store and F-Droid badges chore: Fix dimension of images, add title overlay and Play Store and F-Droid badges Aug 14, 2019
@ShridharGoel
Copy link
Member Author

@mariobehling Updated.

@mariobehling
Copy link
Member

mariobehling commented Aug 14, 2019

  • Please don't change the space used by the images. Things should not appear bigger. Keep some space as of now.
    Screenshot from 2019-08-14 16-30-09

  • Gray area on bottom of images is not aligned with images
    Screenshot from 2019-08-14 16-27-35

  • Please add Github badge. We discussed adding Github in the meetings, but I missed adding it into the issue. Please add it as a badge. Thanks!

@mariobehling
Copy link
Member

Please also make the overlay gray a bit darker. The info is difficult to read.

@ShridharGoel
Copy link
Member Author

@mariobehling Updated, please have a look. Where should the GitHub badge be added, next to the Play Store and F-Droid badges?

@mariobehling
Copy link
Member

@mariobehling Updated, please have a look. Where should the GitHub badge be added, next to the Play Store and F-Droid badges?

  • Add Github Badge next to Android badges. Reduce the size of the badge, so they fit all below the screenshot.
  • Reduce the transparency of the overlay area. Names are not readable.

@ShridharGoel
Copy link
Member Author

@mariobehling Updated.

@ShridharGoel
Copy link
Member Author

Also made the text darker so that it is easily readable.

@kushthedude
Copy link
Member

@ShridharGoel All the photos are pixelating, Can you increase the resolution a bit so that they don't pixelate.
Also please resolve this, Makes UI look really bad.
image

@mariobehling
Copy link
Member

@ShridharGoel Please provide a non-pixelated resolution and an actual Github Badge. All three Playstore, Fdroid, Github badges should have the same size.

@mariobehling
Copy link
Member

Merging this as WIP. @ShridharGoel Please finalize the points mentioned here.

@mariobehling mariobehling merged commit 01170fd into fossasia:gh-pages Aug 28, 2019
@ShridharGoel
Copy link
Member Author

@mariobehling On it.

@ShridharGoel ShridharGoel deleted the issue527 branch August 28, 2019 15:19
@abishekvashok
Copy link
Member

@ShridharGoel any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Mobile App Section
4 participants