Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed footer for social icons #237

Closed
wants to merge 8 commits into from
Closed

changed footer for social icons #237

wants to merge 8 commits into from

Conversation

shiftsayan
Copy link
Contributor

Added the new G+ icon and redesigned the footer.

@mananwason
Copy link
Member

What is this commit doing @shiftsayan

@shiftsayan
Copy link
Contributor Author

In my 4 most recent commits, I have:

  1. sorted the G+ icon issue
  2. modified the footer with link to Flickr as well
  3. added three languages to Thank You column

@mananwason
Copy link
Member

Please add some description in all the PR's.

@jigyasa-grover
Copy link
Member

I believe the G+ Icon for mobiles #144 and Flickr icon #233 was resolved.

@jigyasa-grover
Copy link
Member

PR #234 Flickr icon updated.

@shiftsayan
Copy link
Contributor Author

This changes the Google+ logo to the latest Google release and makes the design of the footer more seamless.

@shiftsayan shiftsayan mentioned this pull request Dec 27, 2015
@shiftsayan shiftsayan changed the title gci1 changed footer for social icons Dec 27, 2015
@shiftsayan
Copy link
Contributor Author

The issue has been resolved for the CSS file. Please merge!

@mananwason
Copy link
Member

@shiftsayan Please edit the commit message to something more meaningful and please remove the merge request as well, then we can merge.

@shiftsayan
Copy link
Contributor Author

I hope this sorts it. Thanks!

@mananwason
Copy link
Member

@shiftsayan you have 8 commits in this PR, please look at the GIT.md file in the main repository that can guide you on how to squash commits into one and remove the merge commits.

@SaptakS
Copy link

SaptakS commented Dec 28, 2015

This branch also has some conflicts it seems. Please resolve that..

@shiftsayan shiftsayan closed this Dec 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants