Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a different link to the video :D Added Asciicast video and Made alignment :D #904

Merged
merged 1 commit into from Jan 13, 2018
Merged

Conversation

yashk0thari
Copy link
Member

@yashk0thari yashk0thari commented Jan 13, 2018

Please read and understand everything below
Do not delete any text other than where you are instructed.

Students: If one of them is applicable to you. Please check it.

Check by changing each [ ] to [x] Please take note of the whitespace as it matters.

  • Read and understood (see CONTRIBUTING.md)
  • Included a Preview link and screenshot showning after and before the changes.
  • Images are 240 x 240 [w x h].
  • Included a description of change below.
  • Squashed the commits.

Changes done in this Pull Request

  • If your change will be reflected on the website, please provide a Test-Link (Hint : gh-pages)
  • Fixes#<Issue no.>
    Alignment  #908 --> this is the issue i fixed, rest i have added :D

@yashk0thari
Copy link
Member Author

@yashk0thari
Copy link
Member Author

I have made this PR to change the link to a video which was merged and was under-timed, so i have added more content to the video and so increased the time to make the video acceptable :D

@yashk0thari yashk0thari changed the title Added a different link to the video :D Added a different link to the video :D Added Asciicast video and Made alignment :D Jan 13, 2018
Copy link
Member

@realslimshanky realslimshanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all your commits into one. Rest looks good. Good work, keep it up :)

Aligned button properly

too close to projects, so spaced

Added Asciicast video :D
@yashk0thari
Copy link
Member Author

Squashed all commits @realslimshanky, could you approve now ??

Copy link
Member

@sayak119 sayak119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention issue number that you have fixed

@yashk0thari
Copy link
Member Author

#908 --> this is the issue i fixed, rest i have added :D

@yashk0thari
Copy link
Member Author

@sayak119 could you approve now ??

@realslimshanky
Copy link
Member

#908 --> this is the issue i fixed, rest i have added :D

Please add this to the main PR description on the top.

Copy link
Member

@rupav rupav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rupav rupav merged commit b56868d into fossasia:gh-pages Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants