New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a different link to the video :D Added Asciicast video and Made alignment :D #904
Conversation
https://beta-king.github.io/rainbowgodgci17.fossasia.org/ --> Preview Link :D |
I have made this PR to change the link to a video which was merged and was under-timed, so i have added more content to the video and so increased the time to make the video acceptable :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash all your commits into one. Rest looks good. Good work, keep it up :)
Aligned button properly too close to projects, so spaced Added Asciicast video :D
Squashed all commits @realslimshanky, could you approve now ?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mention issue number that you have fixed
#908 --> this is the issue i fixed, rest i have added :D |
@sayak119 could you approve now ?? |
Please add this to the main PR description on the top. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please read and understand everything below
Do not delete any text other than where you are instructed.
Students: If one of them is applicable to you. Please check it.
Check by changing each
[ ]
to[x]
Please take note of the whitespace as it matters.240 x 240
[w x h].Changes done in this Pull Request
gh-pages
)#<Issue no.>
Alignment #908 --> this is the issue i fixed, rest i have added :D