[Review Needed] Fixing of CSS and JS and adding internal links #641
Conversation
_includes/footer.html
Outdated
| @@ -97,17 +97,17 @@ <h6 class="title">Latest Updates</h6> | |||
| </li> | |||
| <li> | |||
| <a href="https://gitter.im/fossasia/fossasia" target="_blank" rel="noopener noreferrer"> | |||
| <i class="fab fa-gitter"></i> | |||
| <i class="fa fa-comment"></i> | |||
There was a problem hiding this comment.
Why has Gitter been removed?
There was a problem hiding this comment.
I have used fontawesome4.7 and it didn't have gitter icon. The link is working only the icon has been changed. I did this because fontawesome5 was giving garbage icons when used internally.
There was a problem hiding this comment.
Please use frontawesome 5 only.
There was a problem hiding this comment.
The link to gitter should have the gitter icon
_includes/footer.html
Outdated
| </a> | ||
| </li> | ||
| <li> | ||
| <a href="https://www.weibo.com/u/5784920339" target="_blank" rel="noopener noreferrer"> | ||
| <i class="fab fa-weibo"></i> | ||
| <i class="fa fa-weibo"></i> |
There was a problem hiding this comment.
Again, I have used fontawesome 4.7 instead of fontawesome 5 since the later was not giving the expected icons
There was a problem hiding this comment.
Please use frontawesome 5 only
There was a problem hiding this comment.
The icon is correct and works for weibo, hence these changes are justified
Also font awesome 5 icon for weibo is not working
There was a problem hiding this comment.
Please use font awesome 5 as Instagram icon is not working and Gitter should have Gitter icon.
_includes/footer.html
Outdated
| </a> | ||
| </li> | ||
| <li> | ||
| <a href="https://vk.com/fossasia" target="_blank" rel="noopener noreferrer"> | ||
| <i class="fab fa-vk"></i> | ||
| <i class="fa fa-vk"></i> |
There was a problem hiding this comment.
Fontawesome 4.7 uses fa instead of fab
There was a problem hiding this comment.
Please use frontawesome 5 only.
|
Why has the js effect for the **Thank You For Contributing ** section disappeared.Please squash your commits.Why does the GitHub links of the students and mentors appear below the image? |
|
Requesting a review @mariobehling @jogendra @nikit19 |
|
@NishithP2004 @pranav1698 Have added fontawesome 5 and removed fontawesome 4.7. Refer screenshots. |
roninx991
changed the title
|
What has happened to the |
|
Just a suggestion, is there any way you can make the icons etc red? @Sangatdas |
|
Probably by changing the colour gradient. |
Can you provide me with some video or something? I hadn't seen the site before this bug was reported. |
|
@sangatdas you can check the history of commits using 'git log'and then
checkout any previous commit that would point to the previous site
…On Fri, Dec 28, 2018, 12:06 Sangatdas ***@***.*** wrote:
What has happened to the Thank you for contributing which should have a
nice js effect.
Can you provide me with some video or something? I hadn't seen the site
before this bug was reported.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#641 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhJO2YIfFf8lWKX7PuHnEp8aRKx-cWGGks5u9bv-gaJpZM4ZhExv>
.
|
|
You have missed custom.css . It can be added in this PR . It will fix current issues too . You can get that file from previous commits as mentioned by Pranav . |
|
@Sangatdas Please do as requested for the PR to be merged. |
|
I hadn't seen the previous site earlier before making the PR. Now, that I've seen it, I'll be able to make the required changes |
|
I'll be closing this PR and request a new PR since I have to do a lot of changes. Thanks for the reviews and guidance |
Changes done in this Pull Request
Description / Changes
1. Addition of jquery-
Internal jquery has been added as many libraries depended on it. However addition of internal jquery induced some new issues such as broken slider and navbar issues.
2. Navbar Fix-
Fixed navbar according to theme.
3. CSS Fix-
Fixed broken css and fontawesome
4. Image Slider Fix-
Fixed broken image slider using bxslider library instead of flexslider which confilcted with code.
Screenshots if any:
Before:
After: