Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds music to orchestra tile #453

Merged
merged 1 commit into from Jan 13, 2018
Merged

Conversation

abishekvashok
Copy link
Member

Don't delete anything without explicit instructions from a maintainer.

When you change [things like this in brackets] please remember to delete brackets after you change it.

Check by changing each [ ] to [x] Please take note of the whitespace as it matters.

  • Read and understood see CONTRIBUTING.md
  • Included a Preview link and screenshot showning after and before the changes.
  • Included a description of change below.
  • Squashed the commits.

Changes done in this Pull Request

Adds music to orchestra tile as the tile is all about music. The music was composed by me over a guitar and recorded with a phone.

Adds music to orchestra tile as the tile is all about music
@abishekvashok
Copy link
Member Author

Needs reviews @Beta-King @STEdirisuriya @0x48piraj @samyakbvs @YashKumarVerma

Copy link
Member

@0x48piraj 0x48piraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean ! 💯

Copy link
Member

@yashk0thari yashk0thari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds awesome ;D

@abishekvashok
Copy link
Member Author

thanks @0x48piraj @Beta-King

@abishekvashok
Copy link
Member Author

Note: game is not loading not due to any mistake here.

Copy link
Member

@harshit98 harshit98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @abishekvashok 💯

@xeon-zolt xeon-zolt merged commit b4d8394 into fossasia:master Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants