Fixes #27,#34:Footer menu cross-browser ui patches #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 73.40% (diff: 100%)@@ master #37 diff @@
==========================================
Files 12 16 +4
Lines 164 188 +24
Methods 0 0
Messages 0 0
Branches 10 10
==========================================
+ Hits 114 138 +24
Misses 50 50
Partials 0 0
|
|
I have tested for Firefox, Safari and Chrome on OSX and it seems that it should work. I am not so sure about IE11 and edge (Please test) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27,#34
Tested the ui on OSX Chrome, OSX Firefox, OSX Safari (Fixed UI in Gecko)