Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send generator-package array as json-array to the build server - (Solves- #397) #399

Merged
merged 3 commits into from Feb 13, 2019
Merged

Send generator-package array as json-array to the build server - (Solves- #397) #399

merged 3 commits into from Feb 13, 2019

Conversation

pranav1698
Copy link

@pranav1698 pranav1698 commented Feb 12, 2019

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • There is a corresponding issue for this pull request.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes (provide a screenshot or link for test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

This sends the generator-package array from the webapp to the build server sending it as a json array
This array can be further used in the build server for installing packages

Changes proposed in this pull request:

  • Dumping the package array into a json array
  • Sending the json array to the build server with the trigger request

Fixes #397

@pranav1698 pranav1698 changed the title Send generator-package array as json-array to the build server - (Solves- #398) Send generator-package array as json-array to the build server - (Solves- #397) Feb 12, 2019
@pranav1698
Copy link
Author

Copy link
Author

@pranav1698 pranav1698 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tabesin
Copy link
Member

tabesin commented Feb 13, 2019

The terminology packages is equally obscure as features though. It should be made more transparent to a person unfamiliar with the code what is happening there.

ok,go fwd

@pranav1698
Copy link
Author

Should we replace it with softwares??

@tabesin
Copy link
Member

tabesin commented Feb 13, 2019

I called it receipe previously.

@pranav1698
Copy link
Author

Ok, going with recipes

@pranav1698
Copy link
Author

@tabesin please review now

@xeon-zolt
Copy link
Member

xeon-zolt commented Feb 13, 2019

LGTM, not thoroughly checked.

@xeon-zolt
Copy link
Member

I called it receipe previously.

recipe word looks confusing to me

@tabesin
Copy link
Member

tabesin commented Feb 13, 2019

ingredients?

@tabesin tabesin merged commit e69bfcb into fossasia:master Feb 13, 2019
@pranav1698 pranav1698 deleted the send-package branch February 15, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sending the generator package variables to the build server
3 participants