New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds packages in build.sh to be provied by Travis #176

Merged
merged 1 commit into from Aug 23, 2017

Conversation

2 participants
@abishekvashok
Member

abishekvashok commented Aug 22, 2017

Short description

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message >> Mentioned the issue number in the PR body

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

The packages required on the system which is used to make the iso were fetched by build.sh
using apt-get. Travis Ci allows packages to be predefined in the build environment which would
decrease the build time required.

Fixes #40

Signed-off-by: Abishek V Ashok abishekvashok@gmail.com

Adds packages in build.sh to be provied by Travis
The packages required on the system which is used to make the iso were fetched by build.sh
using apt-get. Travis Ci allows packages to be predefined in the build environment which would
decrease the build time required.

Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
@abishekvashok

This comment has been minimized.

Show comment
Hide comment
@abishekvashok

abishekvashok Aug 22, 2017

Member

Please merge only after comparing build times.

Member

abishekvashok commented Aug 22, 2017

Please merge only after comparing build times.

@tabesin

This comment has been minimized.

Show comment
Hide comment
@tabesin

tabesin Aug 22, 2017

Member

Question: In the travis chroot build environment within the travis environment we use zesty while in the travis-ci they currently use trusty. Does that patch apply to the trusty environment of Travis-ci then? Is that even needed?

Member

tabesin commented Aug 22, 2017

Question: In the travis chroot build environment within the travis environment we use zesty while in the travis-ci they currently use trusty. Does that patch apply to the trusty environment of Travis-ci then? Is that even needed?

@abishekvashok

This comment has been minimized.

Show comment
Hide comment
@abishekvashok

abishekvashok Aug 23, 2017

Member

Which patch are you referring to @tabesin this one?

Member

abishekvashok commented Aug 23, 2017

Which patch are you referring to @tabesin this one?

@abishekvashok

This comment has been minimized.

Show comment
Hide comment
@abishekvashok

abishekvashok Aug 23, 2017

Member

Seems like it saves 8mins as of the previous builds

Member

abishekvashok commented Aug 23, 2017

Seems like it saves 8mins as of the previous builds

@tabesin

This comment has been minimized.

Show comment
Hide comment
@tabesin
Member

tabesin commented Aug 23, 2017

@abishekvashok

This comment has been minimized.

Show comment
Hide comment
@abishekvashok

abishekvashok Aug 23, 2017

Member

@tabesin we download some packages before entering chroot environment. By specifying those packages in the .travis.yml, Travis provides those packages beforehand into the docker container it will run our script. So, when the script runs apt-get it won't download those packages again. They are specified outside the chroot environment because they are expected to be at the system the build.sh script is run to get the iso. So, by this PR we get a sharp decrease in build time as the internet in the Travis ci container is not so fast so the package download time can be avoided.

Build time is now 18 mins.

Note: i didnt remove those packages off build.sh so that build.sh works outside Travis CI as well.

Member

abishekvashok commented Aug 23, 2017

@tabesin we download some packages before entering chroot environment. By specifying those packages in the .travis.yml, Travis provides those packages beforehand into the docker container it will run our script. So, when the script runs apt-get it won't download those packages again. They are specified outside the chroot environment because they are expected to be at the system the build.sh script is run to get the iso. So, by this PR we get a sharp decrease in build time as the internet in the Travis ci container is not so fast so the package download time can be avoided.

Build time is now 18 mins.

Note: i didnt remove those packages off build.sh so that build.sh works outside Travis CI as well.

@tabesin

This comment has been minimized.

Show comment
Hide comment
@tabesin

tabesin Aug 23, 2017

Member

Let's try.

Member

tabesin commented Aug 23, 2017

Let's try.

@tabesin tabesin merged commit d62c4d9 into fossasia:master Aug 23, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment