fix: retain value of time and type of event #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarwalpulkit596
force-pushed
the
retainValues
branch
from
4561961
to
fcbf066
Compare
|
@iamareebjamal I can only work on #1561 after this has been merged so please review this ASAP |
|
Peer reviews please |
|
@liveHarshit please review |
|
@liveHarshit any update |
liveHarshit
approved these changes
Apr 10, 2019
|
@iamareebjamal please merge so that I can start working #1561 |
iamareebjamal
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1567
Changes: Saved Time and event type to shared preferences
Screenshots for the change:
