feat: Implement location feature in f-droid build #2008
Conversation
liveHarshit
changed the title
Why not required? |
There was only one module which is configured for location feature, now the location feature is implemented in both variant in the same way, so I have removed the blank module |
|
How was it implemented previously in Google Play Variant? |
There was a ViewModel: WelcomeViewMode same copy of GeoLocationViewModel in flavor specific view model. Now I use the GeoLocationViewModel in place of that.
The same way means ViewModel type is same but location service implementation is different. No change in location service implementation for play variant, I have just implemented the location service class for fdroid variant. |
|
Also, there were two welcome fragments for different variant, which is really not required now. |
| @@ -7,6 +7,8 @@ | |||
| <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" /> | |||
| <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" /> | |||
| <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> | |||
| <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/> | |||
| <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/> | |||
There was a problem hiding this comment.
No use of fine AFAIK, or is there?
There was a problem hiding this comment.
Here LocationManager.NETWORK_PROVIDER is used so fine location is required.
There was a problem hiding this comment.
Fixes #2006