feat: add other options to search events #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You forgot to pull latest commits from upstream. |
nikit19
reviewed
Dec 22, 2018
|
@nikit19 pls review |
nikit19
previously requested changes
Dec 23, 2018
app/src/main/java/org/fossasia/openevent/general/search/SearchTimeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/search/SearchTimeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/search/SearchTimeViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/search/SearchTimeViewModel.kt
Show resolved
Hide resolved
|
Additionally a little more margin between the textviews in search fragment would look good IMO |
app/src/main/java/org/fossasia/openevent/general/search/SearchTimeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/search/SearchTimeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/search/SearchTimeViewModel.kt
Outdated
Show resolved
Hide resolved
@nikit19 done! |
|
@iamareebjamal pls review |
|
@iamareebjamal pls review |
@nikit19 The build is failing due to wildcard import. Pls review |
iamareebjamal
approved these changes
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #733
Screenshots
* Since there is no event this weekend