New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make accept/reject proposal button for sessions functional #1266

Merged
merged 1 commit into from Jun 11, 2018

Conversation

@pradeepgangwar
Copy link
Member

pradeepgangwar commented Jun 9, 2018

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

Currently aceept/reject proposal buttons on sessions route do not work. This PR makes necessary additions and deletions to make it functional.

Changes proposed in this pull request:

  • Defines new actions that allow organizer to accept or reject a proposal with an option to notify user via mail or not.

Fixes #1094

@pradeepgangwar pradeepgangwar force-pushed the pradeepgangwar:issue-1094 branch from 0c69e19 to 04d0085 Jun 9, 2018

@pradeepgangwar pradeepgangwar force-pushed the pradeepgangwar:issue-1094 branch from 04d0085 to c09e9db Jun 9, 2018

@fossasia fossasia deleted a comment from codacy-bot Jun 9, 2018

@@ -54,7 +54,7 @@ export default Route.extend({
filterOptions = [];
}
return this.modelFor('events.view').query('sessions', {
include : 'event,speakers',

This comment has been minimized.

@pradeepgangwar

pradeepgangwar Jun 9, 2018

Member

About removing events from here:

  • When this was included any request to update state of sessions included a empty relation to events and eventually request used to fail stating that event relation should have id.
  • I tried to figure out the actual problem and tried to set relation manually but that meant increased code complexity, logic and was unsuccessful.
  • I realized that we do not actually use that event relation that we are fetching and when I removed this every request was successful since this didn't involve any relation to event.

Let me know if this is wrong. I will dig more deeper into the code and try to see what's the problem/

@open-event-bot

This comment has been minimized.

Copy link

open-event-bot bot commented Jun 9, 2018

Hi @pradeepgangwar!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

open-event-bot bot commented Jun 9, 2018

Hi @pradeepgangwar!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@open-event-bot

This comment has been minimized.

Copy link

open-event-bot bot commented Jun 9, 2018

Hi @pradeepgangwar!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@agbilotia1998
Copy link
Member

agbilotia1998 left a comment

LGTM

@open-event-bot open-event-bot bot removed the needs-review label Jun 11, 2018

@niranjan94 niranjan94 merged commit cd62be3 into fossasia:development Jun 11, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment