Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timer to orders form to indicate time remaining to complete registration #1451

Merged
merged 1 commit into from Jul 20, 2018

Conversation

@pradeepgangwar
Copy link
Member

pradeepgangwar commented Jul 20, 2018

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

Add timer to orders form to indicate time remaining for order to expire.

Changes proposed in this pull request:

  • Add necessary variables and function to achieve the functionality.

Fixes #1450
Part of #750

@pradeepgangwar pradeepgangwar force-pushed the pradeepgangwar:issue-1450 branch from 4c039d7 to e883b4c Jul 20, 2018
@open-event-bot open-event-bot bot removed the needs-review label Jul 20, 2018
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 20, 2018

Codecov Report

Merging #1451 into development will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #1451     +/-   ##
==============================================
- Coverage         27.3%   27.21%   -0.1%     
==============================================
  Files              353      353             
  Lines             2941     2951     +10     
==============================================
  Hits               803      803             
- Misses            2138     2148     +10
Impacted Files Coverage Δ
app/routes/orders/expired.js 0% <ø> (ø) ⬆️
app/components/forms/orders/order-form.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2888cf4...e883b4c. Read the comment docs.

@srv-twry srv-twry merged commit 76b0ee3 into fossasia:development Jul 20, 2018
3 of 5 checks passed
3 of 5 checks passed
codecov/patch 0% of diff hit (target 27.3%)
Details
codecov/project 27.21% (-0.1%) compared to 2888cf4
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.