Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stripe payment support- Step-1 #1474

Merged
merged 1 commit into from Jul 24, 2018

Conversation

@pradeepgangwar
Copy link
Member

commented Jul 23, 2018

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

Currently there is no online payment support.

Changes proposed in this pull request:

  • Add stripe service to support online payment.
  • This PR does not completely resolves the issue.

Next Steps:

Send generated payment token to server to charge user.

Related to #1460
Parent issue #750

@pradeepgangwar

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2018

Stripe testing accounts, debit cards, and credit cards
https://stripe.com/docs/testing
https://stripe.com/docs/connect/testing

@pradeepgangwar pradeepgangwar force-pushed the pradeepgangwar:issue-1460 branch from a37e65d to 368c388 Jul 23, 2018

@fossasia fossasia deleted a comment from open-event-bot bot Jul 23, 2018

@fossasia fossasia deleted a comment from open-event-bot bot Jul 23, 2018

@codecov

This comment has been minimized.

Copy link

commented Jul 23, 2018

Codecov Report

Merging #1474 into development will decrease coverage by 0.18%.
The diff coverage is 3.57%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1474      +/-   ##
===============================================
- Coverage        26.87%   26.69%   -0.19%     
===============================================
  Files              355      357       +2     
  Lines             2988     3012      +24     
===============================================
+ Hits               803      804       +1     
- Misses            2185     2208      +23
Impacted Files Coverage Δ
app/components/orders/order-summary.js 0% <ø> (ø)
app/components/forms/orders/attendee-list.js 0% <ø> (ø) ⬆️
app/routes/orders/placed.js 0% <0%> (ø)
app/controllers/orders/placed.js 0% <0%> (ø)
app/routes/orders/expired.js 0% <0%> (ø) ⬆️
app/controllers/orders/new.js 0% <0%> (ø) ⬆️
app/routes/orders/new.js 0% <0%> (ø) ⬆️
app/routes/orders/view.js 0% <0%> (ø) ⬆️
app/router.js 100% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a93ca5...89c5804. Read the comment docs.

paymentDescription: 'Please fill your card details to proceed',

isNotStripe: computed('model', function() {
return this.get('model.paymentMode') === 'stripe';

This comment has been minimized.

Copy link
@srv-twry

srv-twry Jul 24, 2018

Member

isNotStripe but you're returning True for the case of it being Stripe.

@pradeepgangwar pradeepgangwar force-pushed the pradeepgangwar:issue-1460 branch from 368c388 to 89c5804 Jul 24, 2018

@codacy-bot

This comment has been minimized.

Copy link

commented Jul 24, 2018

Codacy Here is an overview of what got changed by this pull request:

Clones added
============
- app/routes/orders/view.js  1
- app/routes/orders/expired.js  1
- app/routes/orders/new.js  2
         

Clones removed
==============
+ app/components/forms/orders/attendee-list.js  -1
         

See the complete overview on Codacy

@fossasia fossasia deleted a comment from codacy-bot Jul 24, 2018

@open-event-bot open-event-bot bot removed the needs-review label Jul 24, 2018

@srv-twry srv-twry merged commit da37fd7 into fossasia:development Jul 24, 2018

3 of 5 checks passed

codecov/patch 3.57% of diff hit (target 26.87%)
Details
codecov/project 26.69% (-0.19%) compared to 3a93ca5
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.