New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrates event roles API in admin permissions tab #1574

Merged
merged 3 commits into from Aug 5, 2018

Conversation

@agbilotia1998
Copy link
Member

agbilotia1998 commented Aug 5, 2018

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

Integrates event roles API in admin permissions tab.

Changes proposed in this pull request:

  • Integrate event-role-permissions and service APIs.

Fixes #1329

@agbilotia1998 agbilotia1998 force-pushed the agbilotia1998:admin branch from 0912fc6 to b71c70c Aug 5, 2018

@fossasia fossasia deleted a comment from codacy-bot Aug 5, 2018

@pradeepgangwar
Copy link
Member

pradeepgangwar left a comment

LGTM

@open-event-bot open-event-bot bot removed the needs-review label Aug 5, 2018

@agbilotia1998 agbilotia1998 force-pushed the agbilotia1998:admin branch from b71c70c to 1e3fcf8 Aug 5, 2018

@fossasia fossasia deleted a comment from codacy-bot Aug 5, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 5, 2018

Codecov Report

Merging #1574 into development will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1574      +/-   ##
===============================================
- Coverage         25.4%   25.33%   -0.07%     
===============================================
  Files              376      377       +1     
  Lines             3307     3316       +9     
===============================================
  Hits               840      840              
- Misses            2467     2476       +9
Impacted Files Coverage Δ
app/controllers/admin/permissions/event-roles.js 0% <0%> (ø)
app/components/modals/add-system-role-modal.js 16.66% <0%> (-16.67%) ⬇️
app/routes/admin/permissions/event-roles.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efaa432...59fcf6c. Read the comment docs.

@fossasia fossasia deleted a comment from codacy-bot Aug 5, 2018

@fossasia fossasia deleted a comment from codacy-bot Aug 5, 2018

@@ -10,6 +10,12 @@ export default ModalBase.extend(FormMixin, {
this.onValid(() => {
this.sendAction('addSystemRole');
});
},
close() {
if (!this.get('role').get('id')) {

This comment has been minimized.

@CosmicCoder96

CosmicCoder96 Aug 5, 2018

Contributor

umm..does this.get('role.id') not work ?

This comment has been minimized.

@agbilotia1998

agbilotia1998 Aug 5, 2018

Member

Yes, it works. Thanks for pointing out, I have made the changes. Please review :)

@agbilotia1998 agbilotia1998 force-pushed the agbilotia1998:admin branch from 1b28fa5 to 81b1ce4 Aug 5, 2018

@fossasia fossasia deleted a comment from codacy-bot Aug 5, 2018

@fossasia fossasia deleted a comment from codacy-bot Aug 5, 2018

@codacy-bot

This comment has been minimized.

Copy link

codacy-bot commented Aug 5, 2018

Codacy Here is an overview of what got changed by this pull request:

Clones added
============
- app/components/modals/add-system-role-modal.js  1
         

See the complete overview on Codacy

@fossasia fossasia deleted a comment from codacy-bot Aug 5, 2018

@srv-twry srv-twry merged commit c79f5a4 into fossasia:development Aug 5, 2018

3 of 5 checks passed

codecov/patch 0% of diff hit (target 25.4%)
Details
codecov/project 25.33% (-0.07%) compared to efaa432
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment