New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #1597]Integrates system role API in permissions tab #1598

Merged
merged 1 commit into from Aug 14, 2018

Conversation

@agbilotia1998
Copy link
Member

agbilotia1998 commented Aug 7, 2018

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

Integrates system role API in permissions tab.

Changes proposed in this pull request:

  • Integrated the API for custom system-role.

Status:
The relationship for panel-permission needs to be added to custom-system-role API on the server, integration would be done here once it is done on the server.
Fixes #1597

@agbilotia1998 agbilotia1998 force-pushed the agbilotia1998:system-roles branch 3 times, most recently from 905ed9c to 78e49a7 Aug 7, 2018

@agbilotia1998 agbilotia1998 changed the title [WIP - Fixes #1597]Integrates system role API in permissions tab [Fixes #1597]Integrates system role API in permissions tab Aug 14, 2018

@pradeepgangwar
Copy link
Member

pradeepgangwar left a comment

LGTM 👍

@agbilotia1998 agbilotia1998 force-pushed the agbilotia1998:system-roles branch from 78e49a7 to 7facd86 Aug 14, 2018

@fossasia fossasia deleted a comment from open-event-bot bot Aug 14, 2018

@fossasia fossasia deleted a comment from open-event-bot bot Aug 14, 2018

@fossasia fossasia deleted a comment from open-event-bot bot Aug 14, 2018

@fossasia fossasia deleted a comment from open-event-bot bot Aug 14, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #1598 into development will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1598      +/-   ##
===============================================
- Coverage        24.33%   24.19%   -0.15%     
===============================================
  Files              381      381              
  Lines             3448     3468      +20     
===============================================
  Hits               839      839              
- Misses            2609     2629      +20
Impacted Files Coverage Δ
app/routes/admin/permissions/system-roles.js 0% <ø> (ø) ⬆️
app/controllers/admin/permissions/system-roles.js 0% <0%> (ø) ⬆️
app/components/modals/add-system-role-modal.js 14.28% <0%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c5e95...7facd86. Read the comment docs.

@srv-twry

This comment has been minimized.

Copy link
Member

srv-twry commented Aug 14, 2018

@ritikamotwani Please review and merge.

@ritikamotwani ritikamotwani merged commit b5b7c0a into fossasia:development Aug 14, 2018

3 of 5 checks passed

codecov/patch 0% of diff hit (target 24.33%)
Details
codecov/project 24.19% (-0.15%) compared to 27c5e95
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment