Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make discount codes applicable to orders #1631

Merged
merged 1 commit into from Aug 15, 2018

Conversation

@pradeepgangwar
Copy link
Member

commented Aug 13, 2018

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

Currently we cannot apply discount codes to avail discount in tickets.

Changes proposed in this pull request:

  • Make discount codes applicable to orders

Fixes #1558

@open-event-bot open-event-bot bot removed the needs-review label Aug 13, 2018

@srv-twry

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

@pradeepgangwar Please fix the build. Codewise looks good.

@srv-twry

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

@pradeepgangwar Please resolve conflicts.

@pradeepgangwar pradeepgangwar force-pushed the pradeepgangwar:d-codes branch 2 times, most recently from bacdc77 to 853ec04 Aug 14, 2018

@fossasia fossasia deleted a comment from codacy-bot Aug 15, 2018

@fossasia fossasia deleted a comment from open-event-bot bot Aug 15, 2018

@fossasia fossasia deleted a comment from open-event-bot bot Aug 15, 2018

@fossasia fossasia deleted a comment from open-event-bot bot Aug 15, 2018

@pradeepgangwar pradeepgangwar force-pushed the pradeepgangwar:d-codes branch from 853ec04 to bedfa23 Aug 15, 2018

@fossasia fossasia deleted a comment from open-event-bot bot Aug 15, 2018

@codecov

This comment has been minimized.

Copy link

commented Aug 15, 2018

Codecov Report

Merging #1631 into development will increase coverage by 0.1%.
The diff coverage is 14.54%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #1631     +/-   ##
==============================================
+ Coverage        24.19%   24.29%   +0.1%     
==============================================
  Files              381      381             
  Lines             3468     3511     +43     
==============================================
+ Hits               839      853     +14     
- Misses            2629     2658     +29
Impacted Files Coverage Δ
app/routes/public/index.js 0% <ø> (ø) ⬆️
app/components/orders/order-summary.js 33.33% <38.46%> (+33.33%) ⬆️
app/components/public/ticket-list.js 12.82% <7.14%> (-2.08%) ⬇️
app/components/event-card.js 100% <0%> (+16.66%) ⬆️
app/controllers/index.js 77.77% <0%> (+33.33%) ⬆️
app/utils/string.js 100% <0%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b7c0a...bedfa23. Read the comment docs.

@pradeepgangwar

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2018

@ritikamotwani @srv-twry Tests are passing now. Please merge. :)

@srv-twry srv-twry merged commit 46e151a into fossasia:development Aug 15, 2018

3 of 4 checks passed

codecov/patch 14.54% of diff hit (target 24.19%)
Details
codecov/project 24.29% (+0.1%) compared to b5b7c0a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.