Translations download as zip(.po files) button fix

[mrsaicharan1]

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Short description of what this resolves:

Translations as zip can now be downloaded on the admin panel
Related server PR

Fixes #2443

[mrsaicharan1]

Commit history is not related to this. Fixing the pr

[abhinavk96]

A lot of unrelated commits from some other PRs. Sync your repo.

[mrsaicharan1]

@CosmicCoder96 Can you confirm if the link redirect is right here?

[abhinavk96]

@mrsaicharan1 no - this link is supposed to be used for downloading actual .po files like you download pdfs for tickets. The URL has to come from the server where it will be stored.

[mrsaicharan1]

@CosmicCoder96 I've implemented the feature for downloading .po files here in this PR on the server. Won't routing it to /admin/content/translations/all do it?

[abhinavk96]

@mrsaicharan1 You created a namespace on the server - by specifying that the url_prefix is /admin/content/translations/all so you basically created an endpoint on the API. How will routing to that particular url-prefix on the frontend get the file -- that route doesn't exist. You are confusing ember FE routes with API endpoints. They are not interchangeable.

[mrsaicharan1]

@CosmicCoder96 Please correct me if I'm wrong, I'll be creating a model for the translations route where it fetches the data from server asynchronously. Then, I'll be setting the sourceUrl to this.store.findRecord('translations-link') for redirection. Am I right?

[mrsaicharan1]

@CosmicCoder96 Appended the url using the loader service.

[abhinavk96]

Also, you are not using the info available in isLoading anywhere -- use it in conjunction with https://semantic-ui.com/elements/button.html#loading

[mrsaicharan1]

@CosmicCoder96
I believe that the downloads should be working but there's a permanent redirect for the resource.
127.0.0.1 - - [09/Apr/2019 13:21:16] "OPTIONS /v1/admin/content/translations/all HTTP/1.1" 308 -

[abhinavk96]

@mrsaicharan1 what do you mean by permanent redirect?

[mrsaicharan1]

@mrsaicharan1 what do you mean by permanent redirect?

HTTP 308

[abhinavk96]

@mrsaicharan1 Not sure how it's showing on your side: on testing this PR for me it shows a 404
vendor-6d3d450f0fa475b013d3067764daa7a9.js:8357 OPTIONS https://open-event-api-dev.herokuapp.com/v1/admin/content/translations/all? 404 (NOT FOUND)

[mrsaicharan1]

@CosmicCoder96 I've tried out the API request locally and the download works properly when I navigate to https://localhost:5000/v1/admin/content/translations/all

[abhinavk96]

@mrsaicharan1 I have redeployed the server on heroku -- I guess the build of your merged PR is still under progress there. Will test it in a few mins.

[abhinavk96]

@mrsaicharan1 I got this locally, any ideas?

[mrsaicharan1]

@CosmicCoder96 I think it's due to the deletion of the zip file as a celery task. On the server side in app/api/admin_translations.py, if you comment out the lines for deletion as a celery task, the zip is being downloaded. Can you confirm this?

[abhinavk96]

@mrsaicharan1 I will push a pr to create a download file service.. try it after that.

[abhinavk96]

@mrsaicharan1 Use the service I defined in #2540
here.

this.get('loader')
        .downloadFile('/admin/content/translations/all')
        .then(()=> {
         this.get('notify').success(this.get('l10n').t('Translations Zip generated successfully.'));
          })

[mrsaicharan1]

The downloader service helped a lot! It's working perfectly now :)

[abhinavk96]

@mrsaicharan1 Open an issue on the server for the celery task of translation helpers. It is failing for the test deployment with the same error message which I posted a screenshot of before.

[mrsaicharan1]

@CosmicCoder96 Fixed the translations donwload on the server fossasia/open-event-server#5767