Skip to content

Adding tabbed navigation for Confirmed Sessions #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2019
Merged

Adding tabbed navigation for Confirmed Sessions #2890

merged 2 commits into from
May 13, 2019

Conversation

@kushthedude
Copy link
Member

@kushthedude kushthedude commented May 11, 2019

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

  • Adding tabbed navigation for Confirmed Sessions.

Screenshot

Screenshot 2019-05-12 at 1 53 37 AM

Fixes #2889

shreyanshdwivedi
shreyanshdwivedi reviewed May 12, 2019
View reviewed changes
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember adding such a tab in admin sessions in one of my PRs but @ritikamotwani told me to follow what was implemented in v1. Can we start adding features now? @ritikamotwani

@kushthedude
Copy link
Member Author

kushthedude commented May 12, 2019

@shreyanshdwivedi I just saw the Tab to Confirmed Events in Events/Sessions, Thought adding a route in Admin/Events too

@fossasia fossasia deleted a comment May 13, 2019
@pradeepgangwar pradeepgangwar merged commit 46844e1 into fossasia:development May 13, 2019
@kushthedude kushthedude deleted the use branch June 2, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariobehling mariobehling mariobehling approved these changes

+2 more reviewers

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi left review comments

@ritikamotwani ritikamotwani ritikamotwani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No Section For Confirmed Sessions

5 participants

@kushthedude @mariobehling @ritikamotwani @shreyanshdwivedi @pradeepgangwar