Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Addition of landing page for Mobile Application #2979

Merged
merged 2 commits into from May 22, 2019

Conversation

@kushthedude
Copy link
Contributor

kushthedude commented May 20, 2019

Fixes #2929

Changes proposed in this pull request:

  • Added Attendee.hbs
  • Added Organizer.hbs
  • Added images related to pages

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@auto-label auto-label bot added the feature label May 20, 2019
@kushthedude kushthedude changed the title feat: Addition of landing page for pps feat: Addition of landing page for Mobile Application May 20, 2019
Copy link
Contributor

uds5501 left a comment

Please make the UI responsive, as for the Laptop screen, it's working fine.
But being a landing page, it should be responsive as well.

app/templates/attendee-app.hbs Show resolved Hide resolved
@kushthedude

This comment has been minimized.

Copy link
Contributor Author

kushthedude commented May 20, 2019

Copy link
Collaborator

CosmicCoder96 left a comment

Some of the Images are not optimized, 500KB is too big.

app/templates/attendee-app.hbs Show resolved Hide resolved
@kushthedude

This comment has been minimized.

Copy link
Contributor Author

kushthedude commented May 21, 2019

@kushthedude

This comment has been minimized.

Copy link
Contributor Author

kushthedude commented May 21, 2019

@CosmicCoder96 @pradeepgangwar I have reduced sizes as much as possible, Reducing them further will pixelate them, Please provide your reviews

Copy link
Collaborator

CosmicCoder96 left a comment

@kushthedude Attach mobile view and desktop view screenshots.

@kushthedude

This comment has been minimized.

Copy link
Contributor Author

kushthedude commented May 22, 2019

@CosmicCoder96, -:
Desktop View:

image
Screenshot 2019-05-22 at 4 54 06 PM

Mobile View -:
image
image

Since I don't have Scrolling SS in my machine attaching two ss per page

@ritikamotwani ritikamotwani merged commit bf8b014 into fossasia:development May 22, 2019
7 checks passed
7 checks passed
Header rules No header rules processed
Details
Pages changed 6 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Mixed content No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@kushthedude kushthedude deleted the kushthedude:landing branch Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.