Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented event invoice table for organizers #3230

Merged
merged 6 commits into from Aug 13, 2019

Conversation

@mrsaicharan1
Copy link
Member

mrsaicharan1 commented Jul 3, 2019

Fixes #3118

Short description of what this resolves:

This feature adds the tables required for event invoices which shows the upcoming, paid and due event invoices along with relevant information.

Screenshots

As soon as the server implementation for event invoices are functional, the event invoices will show up here along with their respective invoice links.
Screenshot 2019-07-31 at 3 06 51 PM

Changes proposed in this pull request:

  • Filter upcoming, paid and due invoices
  • Added controller for event-invoices
  • Designed template for event invoices

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@auto-label auto-label bot added the feature label Jul 3, 2019
@mrsaicharan1 mrsaicharan1 force-pushed the mrsaicharan1:invoice-table branch 5 times, most recently from 19c862d to 946cf2c Jul 3, 2019
@mrsaicharan1 mrsaicharan1 force-pushed the mrsaicharan1:invoice-table branch from 946cf2c to b66aff9 Jul 4, 2019
@mrsaicharan1 mrsaicharan1 force-pushed the mrsaicharan1:invoice-table branch 3 times, most recently from a43b045 to 5a2317f Jul 4, 2019
app/routes/account/billing-info/invoices.js Outdated Show resolved Hide resolved
app/routes/account/billing-info/invoices.js Outdated Show resolved Hide resolved
@mrsaicharan1 mrsaicharan1 force-pushed the mrsaicharan1:invoice-table branch from 6a44229 to 575aebb Jul 4, 2019
Copy link
Collaborator

CosmicCoder96 left a comment

Use ember tables?

@mrsaicharan1

This comment has been minimized.

Copy link
Member Author

mrsaicharan1 commented Jul 4, 2019

Use ember tables?

Yeah, just saw your merged PR. I considered refactoring after this was merged but I'll do it right now as the ember tables are functional

app/controllers/account/billing-info/invoices.js Outdated Show resolved Hide resolved
app/routes/account/billing-info/invoices.js Outdated Show resolved Hide resolved
@mrsaicharan1 mrsaicharan1 changed the title feat: Implemented event invoice table for organizers [WIP]feat: Implemented event invoice table for organizers Jul 8, 2019
@auto-label auto-label bot removed the feature label Jul 8, 2019
@mrsaicharan1 mrsaicharan1 force-pushed the mrsaicharan1:invoice-table branch from 18331a2 to 221c7a4 Jul 8, 2019
@kushthedude

This comment has been minimized.

Copy link
Contributor

kushthedude commented Jul 8, 2019

Use ember tables for all pending and past too.

@mrsaicharan1

This comment has been minimized.

Copy link
Member Author

mrsaicharan1 commented Jul 8, 2019

Use ember tables for all pending and past too.

Pending & past invoices ? What does that mean?

app/routes/account/billing-info/invoices.js Outdated Show resolved Hide resolved
app/templates/account/billing-info/invoices.hbs Outdated Show resolved Hide resolved
app/controllers/account/billing-info/invoices.js Outdated Show resolved Hide resolved
app/controllers/account/billing-info/invoices.js Outdated Show resolved Hide resolved
app/controllers/account/billing-info/invoices.js Outdated Show resolved Hide resolved
@kushthedude

This comment has been minimized.

Copy link
Contributor

kushthedude commented Jul 8, 2019

Use ember tables for all pending and past too.

Pending & past invoices ? What does that mean?

You understood it correctly 😄

@mrsaicharan1 mrsaicharan1 force-pushed the mrsaicharan1:invoice-table branch from 7347220 to 6fa5635 Jul 9, 2019
app/controllers/account/billing-info/invoices.js Outdated Show resolved Hide resolved
app/controllers/account/billing-info/invoices.js Outdated Show resolved Hide resolved
app/controllers/account/billing-info/invoices.js Outdated Show resolved Hide resolved
app/controllers/account/billing-info/invoices.js Outdated Show resolved Hide resolved
@fossasia fossasia deleted a comment Jul 9, 2019
@mrsaicharan1 mrsaicharan1 force-pushed the mrsaicharan1:invoice-table branch from 3bf8558 to 770f48a Jul 9, 2019
@mrsaicharan1 mrsaicharan1 force-pushed the mrsaicharan1:invoice-table branch 3 times, most recently from cfcb564 to 863a70e Aug 5, 2019
@fossasia fossasia deleted a comment Aug 5, 2019
@mrsaicharan1 mrsaicharan1 force-pushed the mrsaicharan1:invoice-table branch from e15ebe7 to aa2ad13 Aug 5, 2019
@fossasia fossasia deleted a comment Aug 5, 2019
Copy link
Member

shreyanshdwivedi left a comment

LGTM 👍

@mrsaicharan1 mrsaicharan1 dismissed stale reviews from uds5501 and shreyanshdwivedi via 172b1f1 Aug 7, 2019
@mrsaicharan1 mrsaicharan1 force-pushed the mrsaicharan1:invoice-table branch from 172b1f1 to b10b014 Aug 7, 2019
@mrsaicharan1

This comment has been minimized.

Copy link
Member Author

mrsaicharan1 commented Aug 7, 2019

I have shifted the logic to controllers & removed repetitive template code. Please have a look now.

mrsaicharan1 and others added 2 commits Aug 10, 2019
@fossasia fossasia deleted a comment Aug 10, 2019
@fossasia fossasia deleted a comment Aug 11, 2019
@mrsaicharan1

This comment has been minimized.

Copy link
Member Author

mrsaicharan1 commented Aug 11, 2019

@CosmicCoder96 Made the requested changes. Please have a look.

@fossasia fossasia deleted a comment Aug 13, 2019
@CosmicCoder96 CosmicCoder96 merged commit c00e254 into fossasia:development Aug 13, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Pages changed 6 new files uploaded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.