Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notify services in files #3438

Merged
merged 11 commits into from Aug 26, 2019

Conversation

@kushthedude
Copy link
Contributor

kushthedude commented Aug 18, 2019

refers: #3437

@auto-label auto-label bot added the fix label Aug 18, 2019
kushthedude added 2 commits Aug 18, 2019
@kushthedude

This comment has been minimized.

Copy link
Contributor Author

kushthedude commented Aug 18, 2019

@CosmicCoder96 Please have a look here

Copy link
Collaborator

CosmicCoder96 left a comment

What does adding id do, can you add a link to the docs

@kushthedude

This comment has been minimized.

@kushthedude kushthedude requested a review from CosmicCoder96 Aug 19, 2019
app/components/account/danger-zone.js Outdated Show resolved Hide resolved
@kushthedude kushthedude force-pushed the kushthedude:98 branch from c6d44a3 to ab224fa Aug 20, 2019
@kushthedude kushthedude force-pushed the kushthedude:98 branch from ab224fa to dbf9b5c Aug 20, 2019
@fossasia fossasia deleted a comment Aug 20, 2019
@kushthedude

This comment has been minimized.

Copy link
Contributor Author

kushthedude commented Aug 21, 2019

@CosmicCoder96 Please REview

@fossasia fossasia deleted a comment Aug 21, 2019
@fossasia fossasia deleted a comment Aug 21, 2019
@fossasia fossasia deleted a comment Aug 22, 2019
@fossasia fossasia deleted a comment Aug 22, 2019
@kushthedude

This comment has been minimized.

Copy link
Contributor Author

kushthedude commented Aug 23, 2019

@CosmicCoder96 CosmicCoder96 merged commit 6a563e2 into fossasia:development Aug 26, 2019
4 of 6 checks passed
4 of 6 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview processing.
Details
Header rules No header rules processed
Details
Pages changed 6 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
@kushthedude kushthedude deleted the kushthedude:98 branch Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.