Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to hide map in explore route. #3444

Merged
merged 6 commits into from Sep 2, 2019

Conversation

@Anupam-dagar
Copy link
Member

Anupam-dagar commented Aug 19, 2019

Fixes: #3122

Short description of what this resolves:
Currently there is no option to hide map in sidebar

Changes proposed in this pull request:
Add a button which toggles map visibility for mobile views.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Screenshots

61171978-591c0300-a59c-11e9-8082-2bc465a5a3d2

61171977-58836c80-a59c-11e9-9b9c-12fbce338a4b

61171976-58836c80-a59c-11e9-9282-e6c14ba93ec0

@auto-label auto-label bot added the feature label Aug 19, 2019
@Anupam-dagar

This comment has been minimized.

Copy link
Member Author

Anupam-dagar commented Aug 19, 2019

@uds5501 I have imported get and used it too. Can you see why travis is failing?

@fossasia fossasia deleted a comment Aug 20, 2019
Copy link
Member

mrsaicharan1 left a comment

@Anupam-dagar Please check if this breaks any functionality related to the actions you have refactored(es5->es6)

Copy link
Contributor

kushthedude left a comment

Checked on deployment and local, working as expected

Copy link
Contributor

uds5501 left a comment

Tested on netlify deployment, maps are working as expected.

@fossasia fossasia deleted a comment Aug 31, 2019
@CosmicCoder96 CosmicCoder96 merged commit f58911e into fossasia:development Sep 2, 2019
7 checks passed
7 checks passed
Header rules No header rules processed
Details
Pages changed 6 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Mixed content No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.