Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: link event logo and name to event dashboard #4904

Merged
merged 2 commits into from Sep 3, 2020

Conversation

snitin315
Copy link
Member

Fixes #4885

Short description of what this resolves:

  • On the table please link the logo and event name to the specific event dashboard (of the event itself).
  • Slightly increase the space between the logo and event name
  • Slightly decrease the space between the event name and the below buttons

Changes proposed in this pull request:

Before

Screenshot at 2020-08-28 19-11-42

After

Screenshot at 2020-08-28 19-10-12

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Aug 28, 2020
@vercel
Copy link

vercel bot commented Aug 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/f84k50kmc
✅ Preview: https://open-event-frontend-git-fork-snitin315-fix-event-dashbord.eventyay.vercel.app

@mariobehling
Copy link
Member

Screenshot at 2020-08-28 19-10-12

Thanks please move it in the middle. Before it was too close to the image. Now it is too close to the icons.

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #4904 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4904   +/-   ##
============================================
  Coverage        23.17%   23.17%           
============================================
  Files              481      481           
  Lines             5096     5096           
  Branches            18       18           
============================================
  Hits              1181     1181           
  Misses            3911     3911           
  Partials             4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5fb628...02c8ec3. Read the comment docs.

@snitin315
Copy link
Member Author

/cc @mariobehling how about this?

Screenshot at 2020-08-29 14-37-04

@iamareebjamal iamareebjamal merged commit 3daf835 into fossasia:development Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizer Manage Event Overview Dashboard: Link logo and event name to specific event dashboard
3 participants