Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verticle timeline #5002

Merged
merged 2 commits into from Sep 7, 2020
Merged

feat: add verticle timeline #5002

merged 2 commits into from Sep 7, 2020

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Sep 7, 2020

Fixes #

Screenshot from 2020-09-07 21-50-49

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/cicag4mz5
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-1.eventyay.vercel.app

@maze-runnar
Copy link
Contributor Author

I have deleted the fork due to some issue, and fork again the project, so creating a new PR for this with updated changes. #4921 updates.

@mariobehling
Copy link
Member

Thanks. Looks good to me.

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #5002 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5002   +/-   ##
============================================
  Coverage        22.66%   22.66%           
============================================
  Files              485      485           
  Lines             5153     5153           
  Branches            21       21           
============================================
  Hits              1168     1168           
  Misses            3981     3981           
  Partials             4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca424e2...2aca310. Read the comment docs.

@iamareebjamal iamareebjamal changed the title enh: adding verticle timeline feat: add verticle timeline Sep 7, 2020
@auto-label auto-label bot added the feature label Sep 7, 2020
@iamareebjamal iamareebjamal merged commit 6bf863a into fossasia:development Sep 7, 2020
@mariobehling
Copy link
Member

Ok, I see it is deployed, but it seems to work only in a specific screen resolution. Does not work well on a number of resolutions.

Screenshot from 2020-09-07 19-16-49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants