New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move edit and delete options to toolbar for TracksFragment #963 #964

Merged
merged 2 commits into from May 22, 2018

Conversation

3 participants
@mishuvs
Member

mishuvs commented May 20, 2018

Fixes #963

Changes:

  1. moves edit and delete options from every item in the list to the toolbar
  2. allows the user to long press an item to edit or delete it
  3. supports multiple deletions
  4. removes edit option in case of multiple selections
  5. re-clicking the last selected item unselects
  6. re-clicking the only selected item resets the toolbar

Gif deletion:

videotogif_2018 05 22_22 17 45

Gif Updation:

videotogif_2018 05 20_13 22 24 1

@open-event-bot

This comment has been minimized.

Show comment
Hide comment
@open-event-bot

open-event-bot bot May 20, 2018

Hi @mishuvs!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

open-event-bot bot commented May 20, 2018

Hi @mishuvs!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@fossasia fossasia deleted a comment from codacy-bot May 20, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot May 20, 2018

Codecov Report

Merging #964 into development will decrease coverage by 0.33%.
The diff coverage is 1%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development     #964      +/-   ##
=================================================
- Coverage          29.18%   28.85%   -0.34%     
  Complexity           548      548              
=================================================
  Files                158      158              
  Lines               5242     5306      +64     
  Branches             180      188       +8     
=================================================
+ Hits                1530     1531       +1     
- Misses              3647     3710      +63     
  Partials              65       65
Impacted Files Coverage Δ Complexity Δ
...p/core/track/list/viewholder/TracksViewHolder.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../openevent/app/core/track/list/TracksFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/openevent/app/core/track/list/TracksAdapter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...openevent/app/core/track/list/TracksPresenter.java 27.55% <1.78%> (-23.43%) 7 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb0786f...7442b3f. Read the comment docs.

codecov bot commented May 20, 2018

Codecov Report

Merging #964 into development will decrease coverage by 0.33%.
The diff coverage is 1%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development     #964      +/-   ##
=================================================
- Coverage          29.18%   28.85%   -0.34%     
  Complexity           548      548              
=================================================
  Files                158      158              
  Lines               5242     5306      +64     
  Branches             180      188       +8     
=================================================
+ Hits                1530     1531       +1     
- Misses              3647     3710      +63     
  Partials              65       65
Impacted Files Coverage Δ Complexity Δ
...p/core/track/list/viewholder/TracksViewHolder.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../openevent/app/core/track/list/TracksFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/openevent/app/core/track/list/TracksAdapter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...openevent/app/core/track/list/TracksPresenter.java 27.55% <1.78%> (-23.43%) 7 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb0786f...7442b3f. Read the comment docs.

@mishuvs mishuvs changed the title from [W.I.P] feat: Move edit and delete options to toolbar for TracksFragment #963 to feat: Move edit and delete options to toolbar for TracksFragment #963 May 20, 2018

@mishuvs

This comment has been minimized.

Show comment
Hide comment
@mishuvs

mishuvs May 20, 2018

Member

@iamareebjamal Please review

Member

mishuvs commented May 20, 2018

@iamareebjamal Please review

@iamareebjamal

This comment has been minimized.

Show comment
Hide comment
@iamareebjamal

iamareebjamal May 20, 2018

Member

Only cardview should be highlighted

Track deleted is shown before the tracks are deleted. No visual progress on deleting

Member

iamareebjamal commented May 20, 2018

Only cardview should be highlighted

Track deleted is shown before the tracks are deleted. No visual progress on deleting

@fossasia fossasia deleted a comment from codacy-bot May 22, 2018

@mishuvs

This comment has been minimized.

Show comment
Hide comment
@mishuvs

mishuvs May 22, 2018

Member

@iamareebjamal Please review

Member

mishuvs commented May 22, 2018

@iamareebjamal Please review

@open-event-bot open-event-bot bot removed the needs-review label May 22, 2018

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot May 22, 2018

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/src/main/java/org/fossasia/openevent/app/core/track/list/TracksFragment.java  1
- app/src/main/java/org/fossasia/openevent/app/core/track/list/TracksPresenter.java  4
         

Complexity decreasing per file
==============================
+ app/src/main/java/org/fossasia/openevent/app/core/track/list/viewholder/TracksViewHolder.java  -1
         

Clones removed
==============
+ app/src/main/java/org/fossasia/openevent/app/core/track/list/TracksFragment.java  -1
         

See the complete overview on Codacy

codacy-bot commented May 22, 2018

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/src/main/java/org/fossasia/openevent/app/core/track/list/TracksFragment.java  1
- app/src/main/java/org/fossasia/openevent/app/core/track/list/TracksPresenter.java  4
         

Complexity decreasing per file
==============================
+ app/src/main/java/org/fossasia/openevent/app/core/track/list/viewholder/TracksViewHolder.java  -1
         

Clones removed
==============
+ app/src/main/java/org/fossasia/openevent/app/core/track/list/TracksFragment.java  -1
         

See the complete overview on Codacy

@fossasia fossasia deleted a comment from codacy-bot May 22, 2018

@iamareebjamal iamareebjamal merged commit 2d69528 into fossasia:development May 22, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mishuvs mishuvs deleted the mishuvs:toolbar#963 branch May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment