New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add absorb fees/pass on fees to tickets #2925
Conversation
d43c510
to
b7c1e38
Compare
Please squash the commits. I feel these 3 commits shouldn't be separate. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits
Also please make a commit for the backend in this pull request only... Only frontend doesn't make any sense in my opinion. |
b7c1e38
to
a150709
Compare
Absolutely. Thank you. @SaptakS But, let's then only merge when the backend has been implemented. So, we don't get people who will file a bug report as this feature is still under development. @shubham-padia Please make the PR for the backend when you are ready and we merge each of the PRs then. Looks good to me. Cheers. |
@mariobehling sounds good to me. That was my point that people might start thinking it as bug without backend. |
@shubham-padia please resolve codacy issues. |
b4f31f8
to
735e47a
Compare
Current coverage is 76.20% (diff: 64.00%)
@@ development #2925 diff @@
=============================================
Files 219 219
Lines 14467 14487 +20
Methods 0 0
Messages 0 0
Branches 0 0
=============================================
- Hits 11042 11040 -2
- Misses 3425 3447 +22
Partials 0 0
|
74aea71
to
34609e7
Compare
@SaptakS Ready to merge :) |
fixes #2894.
fixes #2924 .