Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add absorb fees/pass on fees to tickets #2925

Merged
merged 3 commits into from Jan 12, 2017
Merged

add absorb fees/pass on fees to tickets #2925

merged 3 commits into from Jan 12, 2017

Conversation

shubham-padia
Copy link
Member

@shubham-padia shubham-padia commented Jan 11, 2017 •
edited

fixes #2894.
fixes #2924 .

selection_065

selection_066

selection_067

@shubham-padia shubham-padia mentioned this pull request Jan 11, 2017
Merged
@SaptakS
Copy link
Contributor

SaptakS commented Jan 11, 2017

Please squash the commits. I feel these 3 commits shouldn't be separate. Thanks.

SaptakS
SaptakS suggested changes Jan 11, 2017
View reviewed changes
Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits

@SaptakS
Copy link
Contributor

SaptakS commented Jan 11, 2017

Also please make a commit for the backend in this pull request only... Only frontend doesn't make any sense in my opinion.

@SaptakS SaptakS mentioned this pull request Jan 11, 2017
Closed
@shubham-padia
Copy link
Member Author

@SaptakS Thanks. I'll resolve #2924 in this PR only 👍 , was just trying to follow 1 PR -> 1 issue which I personally find convenient to work with 😄 .

@mariobehling
Copy link
Member

was just trying to follow 1 PR -> 1 issue which I personally find convenient to work with

Absolutely. Thank you.

@SaptakS But, let's then only merge when the backend has been implemented. So, we don't get people who will file a bug report as this feature is still under development.

@shubham-padia Please make the PR for the backend when you are ready and we merge each of the PRs then. Looks good to me. Cheers.

@SaptakS
Copy link
Contributor

SaptakS commented Jan 12, 2017

@mariobehling sounds good to me. That was my point that people might start thinking it as bug without backend.

@SaptakS
Copy link
Contributor

SaptakS commented Jan 12, 2017

@shubham-padia please resolve codacy issues.

@shubham-padia shubham-padia force-pushed the development branch 2 times, most recently from b4f31f8 to 735e47a Compare January 12, 2017 17:18
@codecov-io
Copy link

codecov-io commented Jan 12, 2017 •
edited

Current coverage is 76.20% (diff: 64.00%)

Merging #2925 into development will decrease coverage by 0.11%

@@           development      #2925   diff @@
=============================================
  Files              219        219          
  Lines            14467      14487    +20   
  Methods              0          0          
  Messages             0          0          
  Branches             0          0          
=============================================
- Hits             11042      11040     -2   
- Misses            3425       3447    +22   
  Partials             0          0

Powered by Codecov. Last update 30fb490...28c2dec

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 75.964% when pulling 28c2dec on shubham-padia:development into 30fb490 on fossasia:development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 75.964% when pulling 28c2dec on shubham-padia:development into 30fb490 on fossasia:development.

@shubham-padia
Copy link
Member Author

@SaptakS Ready to merge :)

@SaptakS SaptakS merged commit 675bfa2 into fossasia:development Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niranjan94 niranjan94 niranjan94 approved these changes

@SaptakS SaptakS SaptakS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@shubham-padia @SaptakS @mariobehling @codecov-io @coveralls @niranjan94