Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update proguard rules file #1197

Merged
merged 1 commit into from Jul 11, 2018

Conversation

2 participants
@sridharjajoo
Copy link
Member

commented Jul 11, 2018

Fixes #1196

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes: Updated proguard rules file.

Screenshots for the change:

@iamareebjamal

This comment has been minimized.

Copy link
Member

commented Jul 11, 2018

Replace the two openevent lines with

-keep class org.fossasia.openevent.app.data.** {
  *;
}

@sridharjajoo sridharjajoo force-pushed the sridharjajoo:proguard_bug branch from 6da248b to cfbccb4 Jul 11, 2018

@sridharjajoo sridharjajoo changed the title chore: Disable proguard in release version chore: Update proguard rules file Jul 11, 2018

@codecov

This comment has been minimized.

Copy link

commented Jul 11, 2018

Codecov Report

Merging #1197 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1197   +/-   ##
==============================================
  Coverage          26.93%   26.93%           
  Complexity           717      717           
==============================================
  Files                197      197           
  Lines               7462     7462           
  Branches             306      306           
==============================================
  Hits                2010     2010           
  Misses              5366     5366           
  Partials              86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90edcc...cfbccb4. Read the comment docs.

@open-event-bot open-event-bot bot removed the needs-review label Jul 11, 2018

@iamareebjamal iamareebjamal merged commit 3dfc91d into fossasia:development Jul 11, 2018

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing c90edcc...cfbccb4
Details
codecov/project 26.93% remains the same compared to c90edcc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

iamareebjamal added a commit that referenced this pull request Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.