Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update About The App section and rename it to 'About Us' #1904

Merged
merged 3 commits into from Aug 19, 2019

Conversation

@ShridharGoel
Copy link
Member

commented Aug 18, 2019

Fixes #1903

GIF for the change:

About Us

@auto-label auto-label bot added the chore label Aug 18, 2019

@fossasia fossasia deleted a comment from ci-reporter bot Aug 18, 2019

@fossasia fossasia deleted a comment from ci-reporter bot Aug 18, 2019

@iamareebjamal

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

  1. What's the increase in app size
  2. Everything is hardcoded. It should be configurable
@ShridharGoel

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2019

Everything is hardcoded. It should be configurable

Configurable from where?

@iamareebjamal

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Package name can be queried programmatically. App name as well. Whatever cannot be coded should be configurable from build.gradle

@ShridharGoel

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2019

Okay

@ShridharGoel

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2019

What's the increase in app size

No increase.

@ShridharGoel ShridharGoel force-pushed the ShridharGoel:update-about branch from 3b17a97 to 4af5703 Aug 19, 2019

@fossasia fossasia deleted a comment from codacy-bot Aug 19, 2019

@codacy-bot

This comment has been minimized.

Copy link

commented Aug 19, 2019

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

Complexity increasing per file
==============================
- app/src/main/java/com/eventyay/organizer/core/about/AboutUsFragment.java  2
         

See the complete overview on Codacy

@fossasia fossasia deleted a comment from codacy-bot Aug 19, 2019


public class AboutUsFragment extends BaseFragment {

private AboutUsFragmentBinding binding;

This comment has been minimized.

@fossasia fossasia deleted a comment from codacy-bot Aug 19, 2019

.addItem(legalElement)
.addItem(shareElement);

if (BuildConfig.FLAVOR.equals("playStore")) {

This comment has been minimized.

app/build.gradle Outdated Show resolved Hide resolved

@fossasia fossasia deleted a comment from ci-reporter bot Aug 19, 2019

@fossasia fossasia deleted a comment from ci-reporter bot Aug 19, 2019

@iamareebjamal iamareebjamal merged commit 1f42d46 into fossasia:development Aug 19, 2019

4 checks passed

Mergeable Mergeable Run has been Completed!
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ShridharGoel ShridharGoel deleted the ShridharGoel:update-about branch Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.