New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Overview with scrollbars, long text, draft issue #3059

Closed
mariobehling opened this Issue Jan 29, 2017 · 9 comments

Comments

4 participants
@mariobehling
Copy link
Member

mariobehling commented Jan 29, 2017

The session overview has a few issues:

  • shows scroll bars after saving sessions - Expected: No scrollbars
  • After user adds more information to an accepted session, the session shows up again in draft mode - Expected: Session should stay in same mode as before
  • The abstract text in overview is very long - Expected: Only show the first 200 characters of the abstract

screenshot from 2017-01-29 04-36-14

@mariobehling

This comment has been minimized.

Copy link
Member

mariobehling commented Feb 2, 2017

Thanks, definitely a good improvement and the scroll bar does not appear so often anymore. In some smaller resolutions it is still there. There is a dataTables_scrollBody and overflow hidden in the html causing this. A way to go is also to distribute the column width more efficiently. But please ensure the content appears as part of the page and is not a frame.

screenshot from 2017-02-02 22-20-30

@mariobehling mariobehling reopened this Feb 2, 2017

@SaptakS

This comment has been minimized.

Copy link
Member

SaptakS commented Feb 2, 2017

@mariobehling, the scroll was kept in smaller resolutions to allow scrolling in table in smaller screen to see the entire content. Since the exact width can't be and shouldn't be put, I think for smaller resolution we should let the scroll be there. Maybe we can reduce a few pixels in media queries... But that will break many other designs...

@mariobehling

This comment has been minimized.

Copy link
Member

mariobehling commented Feb 2, 2017

@SaptakS I do not know any modern website that results in scroll bars within the page.

I also see that some columns contain a lot of content in a relatively thin area and other columns have empty spaces. We need a better distribution of the column width.

@SaptakS

This comment has been minimized.

Copy link
Member

SaptakS commented Feb 2, 2017

I also see that some columns contain a lot of content in a relatively thin area and other columns have empty spaces. We need a better distribution of the column width.

I agree to this but that won't solve the problem of showing tables in smaller resolution.

I do not know any modern website that results in scroll bars within the page.

I agree with this. But then we have made tables as our base of showing information from beginning. To replace it, we need to replace it everywhere now and think of some other alternative... Else we need to show them in the form of accordions in smaller screens where you will have only the list of events and click on the event to see the details instead of in table form...

@niranjan94 @magdalenesuo your views???

@SaptakS

This comment has been minimized.

Copy link
Member

SaptakS commented Feb 2, 2017

Also @mariobehling I think we can close this issue and continue this in #3138 because this is a problem in all tables...

@mariobehling

This comment has been minimized.

Copy link
Member

mariobehling commented Feb 2, 2017

Ok, follow up in #3138.

@SaptakS SaptakS closed this Feb 2, 2017

@mariobehling

This comment has been minimized.

Copy link
Member

mariobehling commented Feb 7, 2017

The abstract text showing up in the draft tab is still longer.

screenshot from 2017-02-07 10-35-14

@mariobehling mariobehling reopened this Feb 7, 2017

@Himanshi-Khandelwal

This comment has been minimized.

Copy link
Contributor

Himanshi-Khandelwal commented Feb 8, 2017

@mariobehling It is working fine in my case.
screenshot from 2017-02-09 00 56 37

@SaptakS

This comment has been minimized.

Copy link
Member

SaptakS commented Feb 8, 2017

@mariobehling works fine for me

screenshot from 2017-02-09 01-02-21

@SaptakS SaptakS closed this Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment