New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds device names for attendee check-in #5284

Merged
merged 2 commits into from Aug 6, 2018

Conversation

5 participants
@mishuvs
Copy link
Member

mishuvs commented Aug 6, 2018

Fixes #4907

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Adds attribute device-name-checkin with value as csv for device names

screenshot from 2018-08-06 19-01-55
screenshot from 2018-08-06 19-05-25

@codacy-bot

This comment was marked as outdated.

Copy link

codacy-bot commented Aug 6, 2018

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/api/attendees.py  11
         

See the complete overview on Codacy

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #5284 into development will decrease coverage by 0.1%.
The diff coverage is 11.11%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5284      +/-   ##
===============================================
- Coverage        63.06%   62.95%   -0.11%     
===============================================
  Files              256      256              
  Lines            12296    12322      +26     
===============================================
+ Hits              7754     7757       +3     
- Misses            4542     4565      +23
Impacted Files Coverage Δ
app/api/attendees.py 38.05% <0%> (-7.89%) ⬇️
app/api/schema/attendees.py 100% <100%> (ø) ⬆️
app/models/ticket_holder.py 84% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df97ab...da9997b. Read the comment docs.

@mishuvs

This comment has been minimized.

Copy link
Member

mishuvs commented Aug 6, 2018

@open-event-bot open-event-bot bot removed the needs-review label Aug 6, 2018

@codacy-bot

This comment has been minimized.

Copy link

codacy-bot commented Aug 6, 2018

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/api/attendees.py  11
         

See the complete overview on Codacy

@fossasia fossasia deleted a comment from codacy-bot Aug 6, 2018

@srv-twry srv-twry merged commit fed2c00 into fossasia:development Aug 6, 2018

3 of 5 checks passed

codecov/patch 11.11% of diff hit (target 63.06%)
Details
codecov/project 62.95% (-0.11%) compared to 5df97ab
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Hound No violations found. Woof!
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mishuvs mishuvs deleted the mishuvs:device-name-checkin branch Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment