Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Blueprint for Panel Permissions #5432

Merged

Conversation

prabhupant
Copy link
Contributor

Fixes #5298

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Add API Blueprints for panel permissions

Changes proposed in this pull request:

  • added API blueprints for panel permissions

@abhinavk96
Copy link
Contributor

abhinavk96 commented Oct 21, 2018

Mention Fixes #issue number as in the PR template.

@prabhupant
Copy link
Contributor Author

Mention Fixes #issue number as in the PR template.

@CosmicCoder96 its already mentioned

@abhinavk96 abhinavk96 changed the title Fixes #5298 Add API Blueprint for Panel Permissions Add API Blueprint for Panel Permissions Oct 21, 2018
Copy link
Member

@bhaveshAn bhaveshAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis isn't passing. Please check implementation of other API blueprints thoroughly.

@bhaveshAn
Copy link
Member

Travis is failing due to same reason as #5433 (comment)

@prabhupant prabhupant force-pushed the 5298-panel-permission-api-blueprint branch 3 times, most recently from bd98459 to b32edb1 Compare October 29, 2018 04:25
@prabhupant prabhupant force-pushed the 5298-panel-permission-api-blueprint branch from b32edb1 to 37d7498 Compare October 29, 2018 04:50
@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #5432 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5432   +/-   ##
============================================
  Coverage        62.76%   62.76%           
============================================
  Files              261      261           
  Lines            12623    12623           
============================================
  Hits              7923     7923           
  Misses            4700     4700

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8f972...37d7498. Read the comment docs.

@prabhupant
Copy link
Contributor Author

prabhupant commented Oct 29, 2018

@bhaveshAn please review again now

@bhaveshAn bhaveshAn merged commit 7672490 into fossasia:development Oct 29, 2018
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API blueprints for Panel Permissions
3 participants