From 5e79103da56e8a4b581a9195c9e3edb8c83b074f Mon Sep 17 00:00:00 2001 From: CosmicCoder96 Date: Fri, 26 Jul 2019 06:23:08 +0530 Subject: [PATCH] fix: Make discount code & access code URL follow json api conventions --- app/api/__init__.py | 4 ++-- docs/api/api_blueprint.apib | 4 ++-- tests/hook_main.py | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/api/__init__.py b/app/api/__init__.py index f084ec8c09..3f87b0080a 100644 --- a/app/api/__init__.py +++ b/app/api/__init__.py @@ -474,7 +474,7 @@ '/tickets//discount-codes') api.route(DiscountCodeDetail, 'discount_code_detail', '/discount-codes/', '/events//discount-code', '/event-invoices//discount-code', - '/event//discount-code/') + '/events//discount-codes/') api.route(DiscountCodeRelationshipRequired, 'discount_code_event', '/discount-codes//relationships/event') api.route(DiscountCodeRelationshipOptional, 'discount_code_events', @@ -542,7 +542,7 @@ '/events//access-codes', '/users//access-codes', '/tickets//access-codes') api.route(AccessCodeDetail, 'access_code_detail', '/access-codes/', - '/event//access-code/') + '/events//access-codes/') api.route(AccessCodeRelationshipRequired, 'access_code_event', '/access-codes//relationships/event') api.route(AccessCodeRelationshipOptional, 'access_code_user', diff --git a/docs/api/api_blueprint.apib b/docs/api/api_blueprint.apib index e2e08f3631..7c60931e73 100644 --- a/docs/api/api_blueprint.apib +++ b/docs/api/api_blueprint.apib @@ -17815,7 +17815,7 @@ Delete a single discount code (Check permission to delete). } } -## Get Discount Code Detail using the code [/v1/event/{event_id}/discount-code/{code}] +## Get Discount Code Detail using the code [/v1/events/{event_id}/discount-codes/{code}] + Parameters + code: DC101 (string) - code associated with a discount code. (DC101 is an example of code) + event_id: 1 (integer) - ID of the Event in the form of an integer @@ -18429,7 +18429,7 @@ Delete a single Access code. } } -## Access Code Detail using the Code [/v1/event/{event_id}/access-code/{code}] +## Access Code Detail using the Code [/v1/events/{event_id}/access-codes/{code}] + Parameters + code: AC101 (string) - code of the access-code. + event_id: 1 (integer) - ID of the Event in the form of an integer. diff --git a/tests/hook_main.py b/tests/hook_main.py index 55ac61d907..e266dafba0 100644 --- a/tests/hook_main.py +++ b/tests/hook_main.py @@ -2804,7 +2804,7 @@ def discount_delete(transaction): @hooks.before("Discount Codes > Get Discount Code Detail using the code > Get Discount Code Detail") def discount_code_get_detail_using_code(transaction): """ - GET event/1/discount-codes/DC101 + GET events/1/discount-codes/DC101 :param transaction: :return: """ @@ -2941,7 +2941,7 @@ def access_code_delete(transaction): @hooks.before("Access Codes > Access Code Detail using the Code > Access Code Detail") def access_code_get_detail_using_code(transaction): """ - GET event/1/access-code/AC101 + GET events/1/access-codes/AC101 :param transaction: :return: """