Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cancelled and withdrawn state to session #7146

Merged
merged 1 commit into from Jul 21, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jul 21, 2020

@@ -96,7 +96,7 @@ def validate_fields(self, data, original_data):
signup_url = fields.Url(allow_none=True)
state = fields.Str(
validate=validate.OneOf(
choices=["pending", "accepted", "confirmed", "rejected", "draft"]
choices=["pending", "accepted", "confirmed", "rejected", "draft", "cancelled", "withdrawn"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (103 > 90 characters)

@auto-label auto-label bot added the feature label Jul 21, 2020
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #7146 into development will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7146      +/-   ##
===============================================
- Coverage        62.79%   62.79%   -0.01%     
===============================================
  Files              262      262              
  Lines            13023    13028       +5     
===============================================
+ Hits              8178     8181       +3     
- Misses            4845     4847       +2     
Impacted Files Coverage Δ
app/api/schema/sessions.py 90.90% <ø> (ø)
app/api/helpers/mail.py 27.35% <0.00%> (-1.08%) ⬇️
config.py 88.46% <0.00%> (+0.14%) ⬆️
app/api/helpers/files.py 75.00% <0.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6921187...884af37. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 385f2bc into fossasia:development Jul 21, 2020
@iamareebjamal iamareebjamal deleted the session-state branch July 21, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants