Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds video streaming iframe #1866

Merged
merged 3 commits into from May 21, 2018

Conversation

3 participants
@agbilotia1998
Copy link
Member

commented May 20, 2018

Checklist

Short description of what this resolves:

Adds youtube video player.

Fixes #1810
Preview Link: https://agbilotia1998.github.io/GoogleIO-17/

@geekyd @mariobehling FOSSASIA Summit 17 sample has been updated with the video URLs
Link to the PR: fossasia/open-event#270

@agbilotia1998 agbilotia1998 force-pushed the agbilotia1998:video branch from 7b99551 to 1ebbe82 May 20, 2018


.video {
@include cursorpointer;
padding: 5px;

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot May 20, 2018

Properties should be ordered color, padding, position, right, top

@open-event-bot

This comment has been minimized.

Copy link

commented May 20, 2018

Hi @agbilotia1998!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

agbilotia1998 added some commits May 21, 2018

@open-event-bot open-event-bot bot removed the needs-review label May 21, 2018

@mariobehling mariobehling merged commit 7720131 into fossasia:development May 21, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Hound 1 violation found.
@codecov

This comment has been minimized.

Copy link

commented May 21, 2018

Codecov Report

Merging #1866 into development will increase coverage by 0.14%.
The diff coverage is 91.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1866      +/-   ##
===============================================
+ Coverage        73.05%   73.19%   +0.14%     
===============================================
  Files               10       10              
  Lines             2353     2358       +5     
  Branches           411      416       +5     
===============================================
+ Hits              1719     1726       +7     
+ Misses             634      632       -2
Impacted Files Coverage Δ
src/backend/fold_v2.js 92.6% <91.66%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f79ddc9...fb20c6b. Read the comment docs.

@agbilotia1998 agbilotia1998 deleted the agbilotia1998:video branch Jun 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.