New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1120 App Crash On Clicking Filter Icon #1131

Merged
merged 3 commits into from Sep 15, 2017

Conversation

5 participants
@codedsun
Contributor

codedsun commented Sep 13, 2017

Fix #1120 Toast Msg And Log Is Seen

Changes:
Fixed app crash on clicking filter button on front camera in moto E.

Screenshots for the change:

screenshot_2017-09-14-09-05-58

@mohitmanuja @anantprsd5 Please Review !

@mohitmanuja

This comment has been minimized.

Show comment
Hide comment
@mohitmanuja

mohitmanuja Sep 14, 2017

Contributor

@codedsun Always write issue number in PR description.
I.e
Fix #1120
Changes : Fixed app crash on clicking filter button on front camera in moto G.

Contributor

mohitmanuja commented Sep 14, 2017

@codedsun Always write issue number in PR description.
I.e
Fix #1120
Changes : Fixed app crash on clicking filter button on front camera in moto G.

@codedsun

This comment has been minimized.

Show comment
Hide comment
@codedsun

codedsun Sep 14, 2017

Contributor

@mohitmanuja Done !Comment Updated.

Contributor

codedsun commented Sep 14, 2017

@mohitmanuja Done !Comment Updated.

@fossasia fossasia deleted a comment from codacy-bot Sep 14, 2017

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Sep 14, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/src/main/java/org/fossasia/phimpme/opencamera/Preview/Preview.java  2
         

See the complete overview on Codacy

codacy-bot commented Sep 14, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/src/main/java/org/fossasia/phimpme/opencamera/Preview/Preview.java  2
         

See the complete overview on Codacy

@fossasia fossasia deleted a comment from codacy-bot Sep 14, 2017

@the-dagger the-dagger merged commit c71c828 into fossasia:development Sep 15, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@codedsun codedsun deleted the codedsun:crashfixed branch Sep 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment